Don't warn for $schema element #6927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a `$schema` attribute pointing to the official schema is a nice way to get completion in an editor. This caused a warning during build, however. This checks for that element when building the commands so we don't warn for what is already a supported scenario. Fixes Using $schema to get completion causes a build warning dotnet#6926
yufeih
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
$schemaattribute pointing to the official schema is a nice way to get completion in an editor. This caused a warning during build, however.This checks for that element when building the commands so we don't warn for what is already a supported scenario.
Fixes Using $schema to get completion causes a build warning #6926
Microsoft Reviewers: Open in CodeFlow