Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup and tooling fixes #139

Closed

Conversation

alistairmatthews
Copy link
Contributor

@alistairmatthews alistairmatthews commented Dec 7, 2023

Summary

Changes that address setup and tooling changes for preview.2

Fixes #130


Internal previews

📄 File 🔗 Preview link
docs/setup-tooling.md .NET Aspire setup and tooling

Copy link
Contributor

@balachir balachir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments about workload update

docs/setup-tooling.md Outdated Show resolved Hide resolved
docs/setup-tooling.md Outdated Show resolved Hide resolved
@IEvangelist IEvangelist added the getting-started Content related to getting started. label Dec 8, 2023
Copy link
Contributor

@balachir balachir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fixes. Added one suggestion to add dotnet workload list to the steps. That's a nice-to-have, so I'll go ahead and approve the PR.

```dotnetcli
dotnet workload update
dotnet workload install aspire
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a dotnet workload list after dotnet workload install aspire. That way, customers can verify that they installed the correct version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added an extra step. Thanks!


```dotnetcli
dotnet workload update
dotnet workload install aspire
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a dotnet workload list step after dotnet workload install aspire. That way, customers can verify that they installed the correct version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@alistairmatthews
Copy link
Contributor Author

alistairmatthews commented Dec 11, 2023

@IEvangelist - This PR has two conflicts, I think because setup-tooling.md and projects.png have moved in main. I don't have write access to fix them. Could you resolve them? If not I can close this PR and reopen having pulled again. Thanks!

@IEvangelist
Copy link
Member

@IEvangelist - This PR has two conflicts, I think because setup-tooling.md and projects.png have moved in main. I don't have write access to fix them. Could you resolve them? If not I can close this PR and reopen having pulled again. Thanks!

Hi @alistairmatthews - sorry about the merge conflicts, things have been shifting around a bit. I cannot fix the merge conflicts from the GitHub UX either:

image

@alistairmatthews
Copy link
Contributor Author

@IEvangelist - This PR has two conflicts, I think because setup-tooling.md and projects.png have moved in main. I don't have write access to fix them. Could you resolve them? If not I can close this PR and reopen having pulled again. Thanks!

Hi @alistairmatthews - sorry about the merge conflicts, things have been shifting around a bit. I cannot fix the merge conflicts from the GitHub UX either:

image

Oh right. No problem. I'll close this and create a new PR. Thanks!

@alistairmatthews
Copy link
Contributor Author

Closing to resolve conflicts.

@alistairmatthews alistairmatthews deleted the setup-add-tooling-fixes branch December 13, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
getting-started Content related to getting started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For Aspire preview.2, some more updates are needed to the setup instructions using VS / CLI with aspire
3 participants