-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup and tooling fixes #139
Setup and tooling fixes #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments about workload update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fixes. Added one suggestion to add dotnet workload list
to the steps. That's a nice-to-have, so I'll go ahead and approve the PR.
```dotnetcli | ||
dotnet workload update | ||
dotnet workload install aspire | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add a dotnet workload list
after dotnet workload install aspire
. That way, customers can verify that they installed the correct version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an extra step. Thanks!
|
||
```dotnetcli | ||
dotnet workload update | ||
dotnet workload install aspire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add a dotnet workload list
step after dotnet workload install aspire
. That way, customers can verify that they installed the correct version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
…/docs-aspire into setup-add-tooling-fixes
@IEvangelist - This PR has two conflicts, I think because setup-tooling.md and projects.png have moved in main. I don't have write access to fix them. Could you resolve them? If not I can close this PR and reopen having pulled again. Thanks! |
Hi @alistairmatthews - sorry about the merge conflicts, things have been shifting around a bit. I cannot fix the merge conflicts from the GitHub UX either: |
Oh right. No problem. I'll close this and create a new PR. Thanks! |
Closing to resolve conflicts. |
Summary
Changes that address setup and tooling changes for preview.2
Fixes #130
Internal previews