Don't include deprecated packages #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
May 24, 2024
There was a problem hiding this comment.
This looks great @gewarren
I had some optional suggestions. Once you decide, it's ready to merge.
PackageIndexer/DotnetPackageIndex.cs
Outdated
| @@ -41,12 +41,12 @@ public static async Task CreateAsync(string packageListPath, bool usePreviewVers | |||
| params string[] feedUrls | |||
| ) | |||
| { | |||
| var packages = new List<PackageIdentity>(); | |||
| var packages = new List<(PackageIdentity, bool)>(); | |||
There was a problem hiding this comment.
Throughout this logic, I'd consider named tuples. I think it will make it easier to read:
Suggested change
| var packages = new List<(PackageIdentity, bool)>(); | |
| var packages = new List<(PackageIdentity version, bool isDeprecated)>(); |
There was a problem hiding this comment.
Thanks @BillWagner, I like that much better. Just never used them before!
…into no-deprecated-pakcs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.