Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link #16283

Closed
Youssef1313 opened this issue Dec 16, 2019 · 8 comments · Fixed by dotnet/samples#1855
Closed

Broken link #16283

Youssef1313 opened this issue Dec 16, 2019 · 8 comments · Fixed by dotnet/samples#1855
Assignees
@sdmaclea
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category]
Milestone
December 2019

Comments

@Youssef1313
Copy link
Member

The link for diagnostics tutorials in https://docs.microsoft.com/samples/dotnet/samples/diagnostic-scenarios/ is broken.

cc: @sdmaclea
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Dec 16, 2019
@Thraka Thraka added doc-bug Problem with the content; needs to be fixed [org][type][category] and removed ⌚ Not Triaged Not triaged labels Dec 16, 2019
@Thraka
Copy link
Contributor

Thraka commented Dec 16, 2019

@sdmaclea Do you remember where this link was supposed to go? I couldn't find anything in the git history that points to a file existing there.

@Thraka Thraka added the waiting-on-feedback Waiting for feedback from SMEs before they can be merged label Dec 16, 2019
@sdmaclea
Copy link
Contributor

It is supposed to point at a file which will be introduced by #14110

@Youssef1313
Copy link
Member Author

This PR doesn't have a file called diagnostic-scenarios.md under a tutorial directory. Is the work on this PR still in progress ?

@sdmaclea
Copy link
Contributor

Yes it is still in progress. The layout of the PR changed since the sample was added. That file was removed and the content was placed in docs/core/diagnostics/index.md

@Youssef1313
Copy link
Member Author

So, the link should be updated from diagnostics/tutorials/diagnostic-scenarios.md to diagnostics/index.md ?

@sdmaclea
Copy link
Contributor

Yes.

@Youssef1313 Youssef1313 mentioned this issue Dec 17, 2019
Merged
@Youssef1313
Copy link
Member Author

@sdmaclea, Thanks for confirmation. I've opened a PR in the samples repo. dotnet/samples#1855.

@Youssef1313
Copy link
Member Author

Fixed.

@mairaw mairaw removed the waiting-on-feedback Waiting for feedback from SMEs before they can be merged label Dec 20, 2019
@mairaw mairaw added this to the December 2019 milestone Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdmaclea sdmaclea

Labels
doc-bug Problem with the content; needs to be fixed [org][type][category]
Projects
None yet
Milestone
December 2019
Development

Successfully merging a pull request may close this issue.

Use dotnetcli in DiagnosticScenarios/readme.md Youssef1313/samples
5 participants
@Thraka @dotnet-bot @mairaw @sdmaclea @Youssef1313