Diagnostic mem leak tutorial #14110
Merged
Diagnostic mem leak tutorial #14110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Aug 31, 2019
26 tasks
sdmaclea
force-pushed
the
diagnostioc-scenarios
branch
from
f65d7ee
to
91fcc7d
Compare
|
@samsp-msft I just rebased this on the #13981 PR. It should represent what I have so far. Feedback would be appreciated. |
sdmaclea
force-pushed
the
diagnostioc-scenarios
branch
from
24ddf26
to
cb060ee
Compare
Merged
sdmaclea
force-pushed
the
diagnostioc-scenarios
branch
from
cb060ee
to
b60cb20
Compare
|
@mairaw I would like a first review when you get chance |
sdmaclea
force-pushed
the
diagnostioc-scenarios
branch
from
2a6ee44
to
6b81f02
Compare
mairaw
requested changes
Oct 18, 2019
BillWagner
added
doc-idea
Add tutorials to walk through key use cases.
Remove tutorial overview Use dotnetcli or console as appropriate Add applies to comment Add preparing sections
Fix URLs Fix commands
mairaw
reviewed
Dec 10, 2019
| ms.author: stmaclea | ||
| ms.date: 10/14/2019 | ||
| --- | ||
| # Sample debug target |
There was a problem hiding this comment.
Would it better to call this "Sample .NET Core diagnostics app" or something like that?
There was a problem hiding this comment.
sample debug target does sound a bit too formal. I don't like "Sample .NET Core diagnostics app" it doesn't convey the bad examples message. I did a quick look for common terminology, but didn't find anything. I chose to keep it as is.
Closed
|
@mairaw I applied most of your suggestions as is. Feel free to make any final edits. |
Youssef1313
reviewed
Dec 17, 2019
Youssef1313
reviewed
Dec 17, 2019
Youssef1313
reviewed
Dec 17, 2019
Youssef1313
reviewed
Dec 17, 2019
Prefer the readme in the samples repo
Add periods Consistent list marker
BillWagner
added
dotnet-core/prod
cli/subsvc
and removed
📚 Area - .NET Core Guide
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add tutorials to walk through key use cases