You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that when API reference remarks were imported, all plain lines (i.e. those not part of a list, a blockquote or a heading) had a single leading space added. The problem with this is that when such a line is right after a list, it is considered part of the last item of the list in markdown.
The lines "The MuxLogger registers loggers in the following way:" and "The MuxLogger unregisters loggers in the following way:" are indented by one space, which causes them to be incorrectly considered part of the preceding list.
Lines like "Any loggers registered before the build manager starts the build get the build-started event at the same time as the MuxLogger." are indented by 5 spaces and are correctly considered part of the preceding list. Changing the indentation to 4 spaces would not cause any issue.
I already have two PRs that deal with this issue (#1893, #1948), but it's so pervasive that I think a more global solution is needed.
My questions:
Is this something worth fixing globally (considering it would change many files at once)?
Should the indentation be fixed everywhere, or only where it causes an issue?
Would a PR by me be welcome, or do you have a better way to deal with this?
Would it make sense to fix other issues at the same time? If so, which ones?
I have also created a PR showing one possible solution: #1952.
The text was updated successfully, but these errors were encountered:
It seems that when API reference remarks were imported, all plain lines (i.e. those not part of a list, a blockquote or a heading) had a single leading space added. The problem with this is that when such a line is right after a list, it is considered part of the last item of the list in markdown.
Consider
MuxLogger
(MSDN, docs.ms, source):MuxLogger
registers loggers in the following way:" and "TheMuxLogger
unregisters loggers in the following way:" are indented by one space, which causes them to be incorrectly considered part of the preceding list.MuxLogger
." are indented by 5 spaces and are correctly considered part of the preceding list. Changing the indentation to 4 spaces would not cause any issue.I already have two PRs that deal with this issue (#1893, #1948), but it's so pervasive that I think a more global solution is needed.
My questions:
I have also created a PR showing one possible solution: #1952.
The text was updated successfully, but these errors were encountered: