-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lines in API reference XML files are too long #1230
Comments
That's an interesting issue. I think before you invest any more of your time, let me discuss this with the rest of the team. I did have to manually scan the text for PR #1930 to spot the differences. |
Just plz keep in mind a few things:
|
@guardrex Yeah, if there's a good chance GitHub's UI will be improved in a reasonable timeframe, that is the best solution. Otherwise, when it comes to line length, I was thinking of setting it to the highest value, which works on GitHub without scrolling, which seems to be about 120. |
Display of text in the code files relies on HTML's .blob-code-inner { white-space: pre } ... which results in lines not breaking. One can hack it, such as by using something like Stylebot to override the GH style and set ... .blob-code-inner { white-space: pre-wrap; word-wrap: break-word } That one simple hack wraps many lines. In XML, the hack isn't completely effective: It still won't work inside of RE: Those lines not highlighting changes in diffs. Yeah, that one's on them. Seems like their algorithm that applies the styles, such as |
@svick a workaround I suggest is to install the browser extension "Wide GitHub", which will increase the width of the textarea containers to the full width of the window. |
Tagging @mimisasouvanh @joelmartinez for triaging. |
The lines in XML files in API reference are way too long. This causes several fairly minor, but noticeable annoyances to contributors like me:
My questions (similar to those in dotnet/docs#1951):
I have a work-in-progress code that would fix this here. In case this is deemed worth doing, I would finish it and submit a PR.
The text was updated successfully, but these errors were encountered: