Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "What's New" config to match changes in "Fundamentals" TOC #33826

Closed
BillWagner opened this issue Feb 1, 2023 · 1 comment · Fixed by dotnet/docs-tools#118
Closed

Update "What's New" config to match changes in "Fundamentals" TOC #33826

BillWagner opened this issue Feb 1, 2023 · 1 comment · Fixed by dotnet/docs-tools#118
Assignees
@BillWagner @gewarren
Labels
docs-experience Indicates issues that are about the learn.microsoft.com experience or design [org][type][category] Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution] 🌟 What's New For the "what's new" area.

Comments

@BillWagner
Copy link
Member

BillWagner commented Feb 1, 2023 •
edited by github-actions bot
Loading

See #33797 (comment)

Now that the '.NET Fundamentals' TOC area has been split into multiple areas, the What's new config should reflect that.

It should be just modifying this section of the config file: https://github.com/dotnet/docs/blob/main/.whatsnew.json#L49-L52

Associated WorkItem - 61980
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Feb 1, 2023
@BillWagner BillWagner added docs-experience Indicates issues that are about the learn.microsoft.com experience or design [org][type][category] 🌟 What's New For the "what's new" area. Pri1 High priority, do before Pri2 and Pri3 🗺️ reQUEST Triggers an issue to be imported into Quest. and removed Pri3 ⌚ Not Triaged Not triaged labels Feb 1, 2023
@github-actions github-actions bot removed the 🗺️ reQUEST Triggers an issue to be imported into Quest. label Feb 1, 2023
@BillWagner BillWagner mentioned this issue Feb 1, 2023
Merged
@github-actions github-actions bot added the 📌 seQUESTered Identifies that an issue has been imported into Quest. label Feb 1, 2023
@gewarren
Copy link
Contributor

gewarren commented Feb 1, 2023

@BillWagner I will update the config. However, I'm worried that we'll still get "catch all" duplicates. For example, "core/compatibility" files get put under ".NET breaking changes", but then they're also caught by "core" for ".NET fundamentals". How can we avoid that?

@gewarren gewarren mentioned this issue Feb 1, 2023
Merged
@BillWagner BillWagner mentioned this issue Feb 2, 2023
Closed
BillWagner added a commit to BillWagner/docs-tools that referenced this issue Feb 13, 2023
@BillWagner
Updates belong in 1 header
0677470 
Fixes dotnet#116
Fixes dotnet/docs#33826

There are two important logic changes here. Both are in the PageGenerationService class.

- When a major change is detected, search the configured heading areas in text order to find the first match. That's the area where this change should be located. Add the header to the data record for changes in this file.
- Rework the LINQ query to retrieve the changes by matched header. Because the section header was found earlier, this is a simpler query.
@BillWagner BillWagner mentioned this issue Feb 13, 2023
Merged
@dotnet-bot dotnet-bot added the resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution] label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillWagner BillWagner

@gewarren gewarren

Labels
docs-experience Indicates issues that are about the learn.microsoft.com experience or design [org][type][category] Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution] 🌟 What's New For the "what's new" area.
Projects
No open projects
dotnet/docs February 2023 sprint
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Whats new] Updates belong in 1 header BillWagner/docs-tools
3 participants
@BillWagner @dotnet-bot @gewarren