Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotNetCliToolReference restore does not seem to be implicit #5315

Closed
Aethon opened this issue May 11, 2018 — with docs.microsoft.com · 9 comments
Closed

DotNetCliToolReference restore does not seem to be implicit #5315

Aethon opened this issue May 11, 2018 — with docs.microsoft.com · 9 comments
Labels
doc-enhancement Improve the current content [org][type][category] needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution]

Comments

Copy link

Aethon commented May 11, 2018

Starting with .NET Core 2.0, you don't have to run dotnet restore because it's run implicitly by all commands that require a restore to occur, such as dotnet new, dotnet build and dotnet run.

At 2.0.4 and 2.0.7, DotNetCliToolReferences do not restore automatically. I have to run dotnet restore to get those to resolve. I cannot find documentation supporting this and have not found any issues raised. Is this expected behavior or should I file a bug? And which repo should the issue be reported in?


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@mairaw
Copy link
Contributor

mairaw commented May 11, 2018

Hi @Aethon. Let's first confirm the right behavior and see if this is a doc issue or a product issue.

@KathleenDollard @livarcocc can you guys help with this question?

@mairaw mairaw added doc-enhancement Improve the current content [org][type][category] Area - .NET Core Guide labels May 11, 2018
@livarcocc
Copy link

@rrelyea to comment.

@mairaw
Copy link
Contributor

mairaw commented Jun 4, 2018

@rrelyea can you please help?

@mairaw mairaw added the waiting-on-feedback Waiting for feedback from SMEs before they can be merged label Jun 4, 2018
@nkolev92
Copy link
Contributor

There are no issues that I'm aware of in this space.
DotnetCLIToolReference restore is similar to any project restore.

I verified that quickly by running:

dotnet new mvc
dotnet build /v:n

In logs I see

Committing restore...
         Tool assets file has not changed. Skipping assets file write. Path: C:\Users\user\.nuget\packages\.tools\microsoft.visualstudio.web.codegeneration.tools\2.0.4\netcoreapp2.0\project.assets.json
         Restore completed in 45.63 ms for C:\Users\user\Documents\Code\NuGet\Test\newtooltest\newtooltest.csproj.

This indicates that the tools did get restored.

Maybe the customer is facing some other problems?

@mairaw mairaw added needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution] and removed waiting-on-feedback Waiting for feedback from SMEs before they can be merged labels Jun 27, 2018
@mairaw
Copy link
Contributor

mairaw commented Jun 27, 2018

@Aethon can you provide more information on your problem?

@KathleenDollard
Copy link
Contributor

@nkolev92 did you test in a 2.0 version?

@Aethon could you install .NET Core 2.1 and try this again?

@Aethon
Copy link
Author

Aethon commented Jun 27, 2018 via email

@JRAlexander
Copy link
Contributor

@Aethon, did it work? Thanks!

@mairaw
Copy link
Contributor

mairaw commented Dec 18, 2018

Closing this issue due to the lack of response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-enhancement Improve the current content [org][type][category] needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution]
Projects
None yet
Development

No branches or pull requests

7 participants