Updating image references in hub page #1416
Conversation
|
#sign-off @mairaw This fixes an issue on the live site where the SVGs are being cut off on the Get Started panel. Can I get this merged and published at your convenience? Thanks! |
|
There are some warnings on the build report. Have you seen those? |
|
also @jasongroce, can we rename the files to all be lower caps? |
| @@ -128,7 +117,7 @@ ms.assetid: | |||
| <div class="card"> | |||
| <div class="cardImageOuter"> | |||
| <div class="cardImage"> | |||
| <img src="./docs/images/hub/net-gs-3.svg" alt="" /> | |||
| <img src="articles/images/hub/logo_NETframework.svg" alt="" /> | |||
There was a problem hiding this comment.
the warnings are probably coming from these changed links. can you keep the links in the format "./docs/images/hub/" so we have clean builds?
There was a problem hiding this comment.
Yes, I can update these. Oddly, the ad cards (at the top) use the articles/images/hub format so I thought there was some build system convention for this docset that needed to be followed. And yes, I can change them to lowercase.
There was a problem hiding this comment.
I see the issue. The hover image in the ad cards was pointing to the wrong place; I've made these consistent across the board.
| ms.technology: | ||
| ms.suite: | ||
| ms.assetid: | ||
| description: Learn about .NET |
There was a problem hiding this comment.
we should probably add a more meaningful description if we're going to add this metadata.
There was a problem hiding this comment.
We're trying to include a meta description for SEO purposes, so this is new in the hub page template. If there's nothing better to put there for now, I can remove it.
| <p><a href="/dotnet/articles/standard/components">.NET Architectural Concepts</a></p> | ||
| <p><a href="https://www.microsoft.com/net">Get Started</a></p> | ||
| <p><a href="/dotnet/articles/standard/#a-stroll-through-net">Tour of .NET</a></p> | ||
| <p><a href="/dotnet/articles/about/products">.NET Concepts</a></p> |
There was a problem hiding this comment.
why change this link? that article redirects to the old link: https://github.com/dotnet/docs/blob/master/docs/about/products.md
There was a problem hiding this comment.
I'll have to check these. It's likely that the version in /dotnet/docs was updated separately from the version in the production team's sandbox. I can revert these.
| <p><a href="/dotnet/articles/standard/tour">Tour of .NET</a></p> | ||
| <p><a href="/dotnet/articles/standard/components">.NET Architectural Concepts</a></p> | ||
| <p><a href="https://www.microsoft.com/net">Get Started</a></p> | ||
| <p><a href="/dotnet/articles/standard/#a-stroll-through-net">Tour of .NET</a></p> |
There was a problem hiding this comment.
this new link doesn't exist. has someone asked to change the links in this section?
|
@mairaw This PR is now free of warnings. I believe I also reverted/updated all the links to what they were previously, and I've updated the version in the production repo to match. I'm submitting a separate update to fix the camel-cased images. |
|
#hold-off |
|
Reopening to rebuild to check build warnings on image links. |
|
#sign-off @mairaw I believe all issues are now addressed and the build report is clean. Let me know if you see anything amiss or have any concerns. |
|
LGTM! Thanks @jasongroce! |
No description provided.