Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved fsharp library reference #17004

Merged
merged 3 commits into from Feb 25, 2020
Merged

Conversation

kexugit
Copy link

@kexugit kexugit commented Feb 6, 2020

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

@dnfclas
Copy link

dnfclas commented Feb 6, 2020

CLA assistant check
All CLA requirements met.

@cartermp
Copy link
Contributor

cartermp commented Feb 7, 2020

The markdownlint failures are...enormous. @mairaw what are your thoughts on that, should they all be addressed?

@mairaw
Copy link
Contributor

mairaw commented Feb 7, 2020

Should we merge this to a migration branch so we can party on this? I think some of the linting errors are probably easy to fix with search and replace on VS Code.

@mairaw
Copy link
Contributor

mairaw commented Feb 7, 2020

Some things I'm noticing though that would be good to fix since it impacts redirection:

  • filenames with special characters. We don't need that -[fsharp] on each file name plus some other characters I'm seeing.
  • repeated words on the file path

@mairaw
Copy link
Contributor

mairaw commented Feb 7, 2020

Also snippets should have been moved to https://github.com/dotnet/samples/tree/master/snippets/fsharp instead.

@cartermp
Copy link
Contributor

cartermp commented Feb 7, 2020

Yeah I think a migration branch makes sense.

@mairaw mairaw changed the base branch from master to migration-fsharp February 7, 2020 23:13
@mairaw
Copy link
Contributor

mairaw commented Feb 7, 2020

Migration branch created. Target changed.

@kexugit
Copy link
Author

kexugit commented Feb 14, 2020

@mairaw for updating file names, I think given the amount of files and the requirement, CPS might be a better resource to use. Also is "-[fsharp]" the only thing that needs to be changed? I see other strings in buckets in the file names.

@kexugit
Copy link
Author

kexugit commented Feb 14, 2020

Also snippets should have been moved to https://github.com/dotnet/samples/tree/master/snippets/fsharp instead.

@mairaw can you specify what folder should the snippets be moved to?

@mairaw
Copy link
Contributor

mairaw commented Feb 14, 2020

I think the snippets could be moved under https://github.com/dotnet/samples/tree/master/snippets/fsharp following as similar name as here

so the file that here is under
docs/fsharp/library-reference/snippets/fsarrays/

would go to snippets/fsharp/fsarrays

@mairaw
Copy link
Contributor

mairaw commented Feb 14, 2020

@mairaw
Copy link
Contributor

mairaw commented Feb 14, 2020

@kexugit given this is a different migration, I'd be open to just drop "-[fsharp]" from the file names if that would make things easier.

@kexugit
Copy link
Author

kexugit commented Feb 14, 2020

@kexugit given this is a different migration, I'd be open to just drop "-[fsharp]" from the file names if that would make things easier.

OK. BTW, is '.' allowed in md file names? a lot of files have '.' in the names.

@cartermp
Copy link
Contributor

@mairaw I think all of the snippets already exist in dotnet/samples. In fact, I think I remember importing them and removing the "fs" at the beginning of the name! So they probably don't need to be migrated.

@cartermp
Copy link
Contributor

Hey folks, how can we get this to where we can merge it into the migration branch? I'd love to get started on fixing things up, but I first want to make sure it's in a good enough state to live in that branch.

@mairaw
Copy link
Contributor

mairaw commented Feb 21, 2020

You should be able to merge it @cartermp at any point. Given it's a working branch, there are no requirements. I believe we only need @kexugit to sign the CLA first.

If you have the snippets already, that makes things easier. So you just need to search and replace to fix the paths.

@kexugit periods on the file names are not ideal but are allowed.

@mairaw
Copy link
Contributor

mairaw commented Feb 24, 2020

@cartermp the CLA is signed. Feel free to merge.

@cartermp cartermp merged commit bed2cac into dotnet:migration-fsharp Feb 25, 2020
@hickford
Copy link
Contributor

Community docs link https://fsharp.github.io/fsharp-core-docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants