New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved fsharp library reference #17004
Conversation
The markdownlint failures are...enormous. @mairaw what are your thoughts on that, should they all be addressed? |
Should we merge this to a migration branch so we can party on this? I think some of the linting errors are probably easy to fix with search and replace on VS Code. |
Some things I'm noticing though that would be good to fix since it impacts redirection:
|
Also snippets should have been moved to https://github.com/dotnet/samples/tree/master/snippets/fsharp instead. |
Yeah I think a migration branch makes sense. |
Migration branch created. Target changed. |
@mairaw for updating file names, I think given the amount of files and the requirement, CPS might be a better resource to use. Also is "-[fsharp]" the only thing that needs to be changed? I see other strings in buckets in the file names. |
@mairaw can you specify what folder should the snippets be moved to? |
I think the snippets could be moved under https://github.com/dotnet/samples/tree/master/snippets/fsharp following as similar name as here so the file that here is under would go to snippets/fsharp/fsarrays |
@cartermp I'm also wondering if these don't already exist in samples. For example |
@kexugit given this is a different migration, I'd be open to just drop "-[fsharp]" from the file names if that would make things easier. |
OK. BTW, is '.' allowed in md file names? a lot of files have '.' in the names. |
@mairaw I think all of the snippets already exist in dotnet/samples. In fact, I think I remember importing them and removing the "fs" at the beginning of the name! So they probably don't need to be migrated. |
Hey folks, how can we get this to where we can merge it into the migration branch? I'd love to get started on fixing things up, but I first want to make sure it's in a good enough state to live in that branch. |
You should be able to merge it @cartermp at any point. Given it's a working branch, there are no requirements. I believe we only need @kexugit to sign the CLA first. If you have the snippets already, that makes things easier. So you just need to search and replace to fix the paths. @kexugit periods on the file names are not ideal but are allowed. |
@cartermp the CLA is signed. Feel free to merge. |
Community docs link https://fsharp.github.io/fsharp-core-docs/ |
Summary
Describe your changes here.
Fixes #Issue_Number (if available)