-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix up indentation in formatting guide #18793
Conversation
This was mistakenly suggesting something that won't work. This now uses the formatting that we do in the F# compiler for our own very very long member definitions (sometimes). Fixes #18637
I feel like the ReturnType is too much on the right here:
Shouldn't we split that on to a new line like this?:
|
Sure, seems reasonable |
@gewarren @IEvangelist can we get this one merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One spelling mistake to fix and suggest adding a comma too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we'll - thank you 🙏
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
This was mistakenly suggesting something that won't work. This now uses the formatting that we do in the F# compiler for our own very very long member definitions (sometimes). Fixes #18637