Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding What is .NET 5 article #20299

Merged
merged 20 commits into from Sep 3, 2020
Merged

Adding What is .NET 5 article #20299

merged 20 commits into from Sep 3, 2020

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Aug 26, 2020

Summary

Added initial bits for 'What is .NET 5' article

Fixes #19979, hey @davidfowl - since the purpose of this article is to cover #19979 I am hopeful that you'll let me know if I need to cover anything else.

Preview

✔️ What is .NET 5
✔️ dotnet new

@dotnet-bot dotnet-bot added this to the August 2020 milestone Aug 26, 2020
@IEvangelist IEvangelist changed the title Adding What is .NET 5 article [Draft]: Adding What is .NET 5 article Aug 26, 2020
@IEvangelist IEvangelist self-assigned this Aug 27, 2020
@IEvangelist IEvangelist marked this pull request as ready for review August 31, 2020 19:29
@IEvangelist IEvangelist requested a review from a team as a code owner August 31, 2020 19:29
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback

docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
@IEvangelist IEvangelist changed the title [Draft]: Adding What is .NET 5 article Adding What is .NET 5 article Sep 1, 2020
@BillWagner BillWagner modified the milestones: August 2020, September 2020 Sep 1, 2020
@IEvangelist IEvangelist added the 🏁 Release: .NET 5 Work items for the .NET 5 release label Sep 1, 2020
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- some points mentioned in #19979 aren't here yet (such as ASP.NET Core and EF Core naming), and I left some initial comments and suggestions.

docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

docs/dotnet-five.md Outdated Show resolved Hide resolved
docs/dotnet-five.md Outdated Show resolved Hide resolved
@IEvangelist IEvangelist merged commit effe10d into dotnet:master Sep 3, 2020
@IEvangelist IEvangelist deleted the net5 branch September 3, 2020 19:39
@adegeo
Copy link
Contributor

adegeo commented Sep 3, 2020

@IEvangelist this had some build validation warnings of links to invalid files

image

@IEvangelist
Copy link
Member Author

Hi @adegeo - these were fixed in #20449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET 5 Work items for the .NET 5 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a document clarifying what .NET 5 is
7 participants