Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Signtool-exe.md to include coming crypto changes to the tool #21048

Merged
merged 15 commits into from
Nov 2, 2020

Conversation

jgeurten
Copy link
Contributor

Summary

*Announcing the updates coming to SignTool in the 20236 kit builds
*Aligned documentation between win32 and seccrypto SignTool exe docs
*Added examples for SignTool

Fixes #Issue_Number (if available)

I am a MSFT PM on the Windows code signing feature team (we own Signtool.exe)

@dnfadmin
Copy link

dnfadmin commented Oct 12, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix linter errors

docs/framework/tools/signtool-exe.md Outdated Show resolved Hide resolved
docs/framework/tools/signtool-exe.md Outdated Show resolved Hide resolved
jgeurten and others added 6 commits October 13, 2020 14:59
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@jgeurten
Copy link
Contributor Author

@Youssef1313 @tdykstra any update on this PR? SignTool changes are live and this doc should reflect those changes. Thanks

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some suggestions for style consistency.

docs/framework/tools/signtool-exe.md Outdated Show resolved Hide resolved
docs/framework/tools/signtool-exe.md Outdated Show resolved Hide resolved
docs/framework/tools/signtool-exe.md Outdated Show resolved Hide resolved
docs/framework/tools/signtool-exe.md Outdated Show resolved Hide resolved
docs/framework/tools/signtool-exe.md Outdated Show resolved Hide resolved
jgeurten and others added 5 commits November 2, 2020 10:30
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
@jgeurten
Copy link
Contributor Author

jgeurten commented Nov 2, 2020

LGTM, left some suggestions for style consistency.

Thank you @tdykstra for the suggested changes! I have approved them.

@tdykstra
Copy link
Contributor

tdykstra commented Nov 2, 2020

Thanks -- I'll merge as soon as the build finishes.

@tdykstra tdykstra merged commit f318e9a into dotnet:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants