Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET Framework -> .NET #21194

Merged
merged 7 commits into from Oct 26, 2020
Merged

Update .NET Framework -> .NET #21194

merged 7 commits into from Oct 26, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 23, 2020

Contributes to #21191. This includes updating top-level files in the /docs/standard folder and all files in the /docs/standard/assembly folder.

Moves console apps article to the "Fundamental coding components" section of the Fundamentals TOC. Moves Web Forms events article to ASP.NET repo.

Moves cross-platform articles to /framework/ directory.

Updates .NET Framework analyzer article to be about code analysis in general.

Preview link.

Hide whitespace changes in diff.

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added some suggestions to consider.

…lyzer article; move console app article to fundamentals toc
@gewarren gewarren requested a review from a team as a code owner October 23, 2020 19:30
@@ -725,24 +725,20 @@ items:
href: misc/using-libraries-from-partially-trusted-code.md
- name: Using the Assert Method
href: misc/using-the-assert-method.md
- name: Create console apps
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this under "Fundamentals/Fundamental coding components" TOC.

@@ -725,24 +725,20 @@ items:
href: misc/using-libraries-from-partially-trusted-code.md
- name: Using the Assert Method
href: misc/using-the-assert-method.md
- name: Create console apps
href: ../standard/building-console-apps.md
- name: Consume events in a Web Forms app
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this under Standard/Events TOC.

@gewarren
Copy link
Contributor Author

@adegeo I'll wait for you to take another look since I made significant changes based on your feedback.

docs/fundamentals/toc.yml Outdated Show resolved Hide resolved
docs/fundamentals/toc.yml Show resolved Hide resolved
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the TOC changes, which I think Tom will review, what I see looks great! Thanks for taking my suggestions into consideration! 😄

@gewarren gewarren merged commit 1a62469 into dotnet:master Oct 26, 2020
@gewarren gewarren deleted the nf-headings branch October 26, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants