Publish updated nullable reference type spec #21344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See dotnet/csharplang#4100 Move the included specification for nullable reference types to the C# 9 folder. Update the appropriate metadata to match.
gewarren
approved these changes
Nov 5, 2020
| @@ -88,6 +88,8 @@ | |||
| href: ../../../../_csharplang/proposals/csharp-9.0/records.md | |||
| - name: Top-level statements | |||
| href: ../../../../_csharplang/proposals/csharp-9.0/top-level-statements.md | |||
| - name: Nullable reference types - specification | |||
There was a problem hiding this comment.
Why does this appear twice?
There was a problem hiding this comment.
Because the feature was added in C# 8.0, and is now being updated for C# 9.0. I think it will help findability. On the other hand, do you think it will be confusing to appear twice?
There was a problem hiding this comment.
I think it's probably fine. I did notice in the preview that "proposal" should be plural in the top level node for 8 and 9. (Lines 61 and 85.)
There was a problem hiding this comment.
@BillWagner Not sure if you saw the previous comment.
BillWagner
added
dotnet-csharp/svc
lang-reference/subsvc
and removed
📚 Area - C# Guide
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet/csharplang#4100
Move the included specification for nullable reference types to the C# 9 folder.
Update the appropriate title metadata.
Because nullable reference types was a C# 8.0 feature, I am publishing this speclet in both C# 8.0 and C# 9.0.