Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS0025 #21424

Merged
merged 7 commits into from Nov 12, 2020
Merged

FS0025 #21424

merged 7 commits into from Nov 12, 2020

Conversation

brettrowberry
Copy link
Contributor

@brettrowberry brettrowberry commented Nov 10, 2020

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

see #16177 (comment)

@dnfadmin
Copy link

dnfadmin commented Nov 10, 2020

CLA assistant check
All CLA requirements met.

@brettrowberry
Copy link
Contributor Author

I don't know what to do about Snippets 5000 / build (pull_request):
Project missing. A project (and optionally a solution file) must be in this directory or one of the parent directories to validate and build this code.

I don't think I should have a project or solution file and as far as I can tell, no other .fs files do.

@brettrowberry brettrowberry changed the title Fs0025 FS0025 Nov 10, 2020
@cartermp
Copy link
Contributor

@brettrowberry Thanks for the contribution. It's a recent change to CI; any new additions of files need to be buildable. What happens if you rename it to .fsx?

If that fails, you can just new up a quick project file and include it. It's annoying but it does at least ensure that things compile before they go live.

@brettrowberry
Copy link
Contributor Author

@cartermp That looks like it worked

@brettrowberry
Copy link
Contributor Author

That means I need to update the links in my .md file. I should probably update the script generator and convert Chet’s .fs to .fsx.

@cartermp
Copy link
Contributor

@brettrowberry Yep, that seems like a reasonable thing. Thanks! If you go ahead and do that then this should be good to merge.

@brettrowberry
Copy link
Contributor Author

@cartermp I think I'm done

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great addition and changes. I'll merge this once it's green.

@brettrowberry
Copy link
Contributor Author

Did I break something or is this a super busy repository?

@cartermp
Copy link
Contributor

I think that Bob's Machine Under The Desk (Azure?) is a little busy at the moment

@cartermp cartermp closed this Nov 12, 2020
@cartermp cartermp reopened this Nov 12, 2020
@brettrowberry
Copy link
Contributor Author

Closing and reopening was a stroke of brilliance!

@cartermp cartermp merged commit 840dfd3 into dotnet:master Nov 12, 2020
@brettrowberry brettrowberry deleted the FS0025 branch November 12, 2020 20:55
@brettrowberry
Copy link
Contributor Author

@cartermp
Copy link
Contributor

Usually within a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants