Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 18496 #21677

Merged
merged 6 commits into from
Dec 18, 2020
Merged

Issue 18496 #21677

merged 6 commits into from
Dec 18, 2020

Conversation

mfcallahan
Copy link
Contributor

Summary

Changes per original issue and discussion:

  • Use nameof expression
  • Use expression bodied members
  • Use pattern matching
  • Grammar (removed casual language)

Fixes #18496

@dotnet-bot dotnet-bot added this to the November 2020 milestone Nov 20, 2020
@sughosneo
Copy link
Contributor

sughosneo commented Nov 24, 2020 •
edited
Loading

Hi @mfcallahan, thank you for submitting this PR.

It would be better if we update the reference application eShopOnContainers before we update the docs.
Could you please submit a PR in eShopOnContainers repo as well ? We will test and merge the changes.

@mfcallahan
Copy link
Contributor Author

@sughosneo Thanks, I will submit a pull request for the eShopOnContainers repo.

This was referenced Nov 25, 2020
Closed
Merged
@mfcallahan
Copy link
Contributor Author

@sughosneo Issue 1527 and created and pull request created for eShopOnContainers repo.

@sughosneo
Copy link
Contributor

@sughosneo Issue 1527 and created and pull request created for eShopOnContainers repo.

thank you @mfcallahan , will test and update.

IEvangelist
IEvangelist reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few bits of C# clean up

...itecture/microservices/microservice-ddd-cqrs-patterns/enumeration-classes-over-enum-types.md Outdated Show resolved Hide resolved
...itecture/microservices/microservice-ddd-cqrs-patterns/enumeration-classes-over-enum-types.md Outdated Show resolved Hide resolved
IEvangelist
IEvangelist approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@IEvangelist IEvangelist merged commit d0abdc0 into dotnet:master Dec 18, 2020
@mfcallahan mfcallahan deleted the issue-18496 branch March 27, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@nishanil nishanil Awaiting requested review from nishanil

Assignees
No one assigned
Labels
dotnet-architecture/svc microservices/subsvc
Projects
None yet
Milestone
December 2020
Development

Successfully merging this pull request may close these issues.

few changes
5 participants
@mfcallahan @sughosneo @IEvangelist @BillWagner @dotnet-bot