Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start documenting trim warnings #25324

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Start documenting trim warnings #25324

merged 5 commits into from
Aug 5, 2021

Conversation

agocke
Copy link
Member

@agocke agocke commented Jul 24, 2021

The trim warnings are currently documented at https://github.com/mono/linker/blob/main/docs/error-codes.md
but we want to slowly move over to the official docs.

The trim warnings are currently documented at https://github.com/mono/linker/blob/main/docs/error-codes.md
but we want to slowly move over to the official docs.
@agocke agocke requested review from adegeo and a team as code owners July 24, 2021 02:04
@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 24, 2021
@agocke agocke requested review from tlakollo and sbomer July 24, 2021 02:18
docs/fundamentals/toc.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add the empty index file? It's causing build warnings.

docs/core/deploying/trim-warnings/il2026.md Outdated Show resolved Hide resolved
docs/core/deploying/trim-warnings/il2026.md Outdated Show resolved Hide resolved
docs/core/deploying/trim-warnings/il2026.md Outdated Show resolved Hide resolved
@BillWagner
Copy link
Member

ping @gewarren It looks like all the requested changes have been made.

@gewarren gewarren merged commit 3f8bbfc into dotnet:main Aug 5, 2021
@agocke
Copy link
Member Author

agocke commented Aug 5, 2021

@gewarren Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants