-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude System.MonoTODo from API syntax #2612
Conversation
@mhutch do you agree with this change? |
Doing a force publish on the branch to see if this change needs a full rebuild. |
https://review.docs.microsoft.com/en-us/dotnet/api/system.net.mail.mailaddress.-ctor?view=netframework-4.7&branch=mairaw-patch-3#System_Net_Mail_MailAddress__ctor_System_String_System_String_System_Text_Encoding_ still showing that attribute. @dend who could help validate my changes to see what I'm doing wrong here? |
@mairaw makes sense to me! Perhaps they could go in some kinds of "platform availability notes" section, but they don't belong in the syntax block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. when you are ready.
It's not working. I'll open a new issue for the engineering team to investigate. For now, marking as WIP. Thanks @mhutch. I'll open an issue for us to add that later on. |
@TianqiZhang anything else I should try? |
@mairaw I merged your change to my branch tianzhDevelop, and this attribute is successfully filtered. So please merge this directly to master, it should work. We'll continue on improving incremental PR build in the future. |
Interesting. I also did full builds on mairaw-patch-3 and couldn't see the change on that branch too @TianqiZhang. But I'll merge and see the results. Thanks. |
I don't think we should be displaying that attribute in the syntax blocks for API docs.
Here's an example: https://docs.microsoft.com/en-us/dotnet/api/system.net.mail.mailaddress.-ctor?view=netframework-4.7#System_Net_Mail_MailAddress__ctor_System_String_System_String_System_Text_Encoding_