Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude System.MonoTODo from API syntax #2612

Merged
merged 2 commits into from
Aug 23, 2017
Merged

exclude System.MonoTODo from API syntax #2612

merged 2 commits into from
Aug 23, 2017

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 13, 2017

@mairaw
Copy link
Contributor Author

mairaw commented Jul 13, 2017

@mhutch do you agree with this change?

@mairaw
Copy link
Contributor Author

mairaw commented Jul 13, 2017

Doing a force publish on the branch to see if this change needs a full rebuild.

@mairaw
Copy link
Contributor Author

mairaw commented Jul 13, 2017

@mhutch
Copy link
Member

mhutch commented Jul 14, 2017

@mairaw makes sense to me! Perhaps they could go in some kinds of "platform availability notes" section, but they don't belong in the syntax block.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit: when you are ready.

@mairaw mairaw added the WIP label Jul 18, 2017
@mairaw
Copy link
Contributor Author

mairaw commented Jul 18, 2017

It's not working. I'll open a new issue for the engineering team to investigate. For now, marking as WIP.

Thanks @mhutch. I'll open an issue for us to add that later on.

@mairaw
Copy link
Contributor Author

mairaw commented Aug 20, 2017

@TianqiZhang anything else I should try?

@TianqiZhang
Copy link
Contributor

@mairaw I merged your change to my branch tianzhDevelop, and this attribute is successfully filtered. So please merge this directly to master, it should work. We'll continue on improving incremental PR build in the future.

@mairaw
Copy link
Contributor Author

mairaw commented Aug 23, 2017

Interesting. I also did full builds on mairaw-patch-3 and couldn't see the change on that branch too @TianqiZhang. But I'll merge and see the results. Thanks.

@mairaw mairaw removed the WIP label Aug 23, 2017
@mairaw mairaw merged commit b7b0944 into master Aug 23, 2017
@mairaw mairaw deleted the mairaw-patch-3 branch August 23, 2017 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants