Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for and! #30447

Merged
merged 3 commits into from Aug 10, 2022
Merged

Add documentation for and! #30447

merged 3 commits into from Aug 10, 2022

Conversation

mducharm
Copy link
Contributor

@mducharm mducharm commented Aug 2, 2022

Adds and! section and updates Creating a New Type of Computation Expression table with new methods.

Addresses #28134

@mducharm mducharm requested review from a team and KathleenDollard as code owners August 2, 2022 03:13
@dotnet-bot dotnet-bot added this to the August 2022 milestone Aug 2, 2022
@dnfadmin
Copy link

dnfadmin commented Aug 2, 2022 •
edited

CLA assistant check
All CLA requirements met.

@KathleenDollard
Copy link
Contributor

I'd like some help reviewing this: @dsyme, @vzarytovskii , @baronfel

baronfel
baronfel approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This fits in with the existing docs.

I think it would be very useful to have standalone, miniature examples of different CEs that highlight the use of and!/implicit yields/etc. but that's a later concern :)

vzarytovskii
vzarytovskii approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@vzarytovskii vzarytovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is great, thank you for the contribution!

BillWagner
BillWagner approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra reviews @baronfel & @vzarytovskii

I've reviewed this as well, and I'll :shipit: now.

@BillWagner BillWagner merged commit 6540cfe into dotnet:main Aug 10, 2022
@BillWagner BillWagner mentioned this pull request Mar 28, 2023
Closed
@gewarren gewarren mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@baronfel baronfel baronfel approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@KathleenDollard KathleenDollard Awaiting requested review from KathleenDollard KathleenDollard is a code owner

Assignees
No one assigned
Labels
dotnet-fsharp/svc
Projects
None yet
Milestone
August 2022
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mducharm @dnfadmin @KathleenDollard @BillWagner @baronfel @vzarytovskii @dotnet-bot