Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to Markdownlint-CLI2 #31543

Merged
merged 1 commit into from
Oct 3, 2022
Merged

chore: migrate to Markdownlint-CLI2 #31543

merged 1 commit into from
Oct 3, 2022

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Oct 2, 2022

Summary

Markdownlint-CLI2 and the updated config are the libraries that now power the VSCode. The update JSONC config allows for comments, and directly referencing custom rules if the Docs Authoring ends up splitting them out

@nschonni nschonni requested a review from a team as a code owner October 2, 2022 05:56
@dotnet-bot dotnet-bot added this to the October 2022 milestone Oct 2, 2022
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Oct 2, 2022
BillWagner
BillWagner approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nschonni

This LGTM.

I'll :shipit: now.

@BillWagner BillWagner merged commit 281d1e5 into dotnet:main Oct 3, 2022
@BillWagner
Copy link
Member

Hi @nschonni

Should I make a similar set of changes in the C# ECMA standard repo, dotnet/csharpstandard?

@nschonni nschonni deleted the markdownlint-cli2 branch October 3, 2022 16:15
@nschonni
Copy link
Contributor Author

nschonni commented Oct 3, 2022

Sure, although, might make sense to create a https://github.com/dotnet/workflows and then these common workflows could be centralized, and then re-used in the various repos

@nschonni nschonni mentioned this pull request Oct 3, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community.
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nschonni @BillWagner @dotnet-bot