Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load image datasets from folder #32972

Closed
wants to merge 8 commits into from
Closed

load image datasets from folder #32972

wants to merge 8 commits into from

Conversation

zewditu
Copy link
Contributor

@zewditu zewditu commented Dec 9, 2022

Summary

Describe your changes here.

Fixes #26537

@dotnet-bot dotnet-bot added this to the December 2022 milestone Dec 9, 2022
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Dec 9, 2022
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @zewditu. I added a few suggestions.

docs/machine-learning/how-to-guides/load-data-ml-net.md Outdated Show resolved Hide resolved

Create a model that hold image path and a lebel . `ImagePath` is the absolute path of the image in data source directory. `Label` is the class or category of the actual image file..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Create a model that hold image path and a lebel . `ImagePath` is the absolute path of the image in data source directory. `Label` is the class or category of the actual image file..
Create a model that hold image path and a label. `ImagePath` is the absolute path of the image in data source directory. `Label` is the class or category of the actual image file.

docs/machine-learning/how-to-guides/load-data-ml-net.md Outdated Show resolved Hide resolved
public string Label;
}
```
## Load the Image Data from input directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this needs its own section. It's still part of loading images from files.

Comment on lines 225 to 226
// Shuffle images.
IDataView shuffledFullImagesDataset = mlContext.Data.ShuffleRows(mlContext.Data.LoadFromEnumerable(images));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really needed.

docs/machine-learning/how-to-guides/load-data-ml-net.md Outdated Show resolved Hide resolved
docs/machine-learning/how-to-guides/load-data-ml-net.md Outdated Show resolved Hide resolved
zewditu and others added 6 commits December 9, 2022 14:39
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
@luisquintanilla
Copy link
Contributor

@zewditu is this ready for review again?

@zewditu
Copy link
Contributor Author

zewditu commented Dec 16, 2022

@luisquintanilla yes I have minor updates, but I do not have updates Idataview and image transformers.

@BillWagner BillWagner modified the milestones: July 2023, August 2023 Aug 4, 2023
@BillWagner BillWagner modified the milestones: August 2023, September 2023 Sep 7, 2023
@BillWagner BillWagner modified the milestones: October 2023, November 2023 Nov 3, 2023
@BillWagner
Copy link
Member

@luisquintanilla

Is this still relevant? Can you review and merge / close?

@BillWagner
Copy link
Member

closing as a stale PR

@BillWagner BillWagner closed this Feb 1, 2024
@gewarren gewarren mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-ml/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Working with image data in ML.NET
4 participants