Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Preview 5 breaking changes for ASP.NET #35545

Merged
merged 5 commits into from
May 31, 2023
Merged

Document Preview 5 breaking changes for ASP.NET #35545

merged 5 commits into from
May 31, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented May 30, 2023 •
edited by github-actions bot
Loading

@dotnet-bot dotnet-bot added this to the May 2023 milestone May 30, 2023
@gewarren gewarren requested review from JamesNK, Tratcher and a team May 30, 2023 23:31
BillWagner
BillWagner approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 77b8ff0 into dotnet:main May 31, 2023
8 checks passed
@gewarren gewarren deleted the asp-pre5 branch May 31, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK left review comments

@BillWagner BillWagner BillWagner approved these changes

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
May 2023
5 participants
@gewarren @JamesNK @BillWagner @Tratcher @dotnet-bot