Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update missing HttpClient client parameter #36896

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Update missing HttpClient client parameter #36896

merged 1 commit into from
Aug 31, 2023

Conversation

tanchekwei
Copy link
Contributor

@tanchekwei tanchekwei commented Aug 30, 2023 •
edited by github-actions bot
Loading

Summary

I was confused by the parameter error when following along with the tutorial.

Update the missing HttpClient client parameter in the ProcessRepositoriesAsync method.

Fixes: the bug part (first line) of #33590

Internal previews

📄 File 🔗 Preview link
docs/csharp/tutorials/console-webapiclient.md Tutorial: Make HTTP requests in a .NET console app using C#

@dotnet-bot dotnet-bot added this to the August 2023 milestone Aug 30, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Aug 30, 2023
BillWagner
BillWagner approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @tanchekwei

I'll :shipit: now.

@BillWagner
Copy link
Member

closing and reopening for a fresh build

@BillWagner BillWagner closed this Aug 31, 2023
@BillWagner BillWagner reopened this Aug 31, 2023
@BillWagner BillWagner enabled auto-merge (squash) August 31, 2023 14:50
@BillWagner BillWagner merged commit 5e31cf7 into dotnet:main Aug 31, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc fundamentals/subsvc
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tanchekwei @BillWagner @dotnet-bot