Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ValidateSettingsOptions.cs #36920

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Update ValidateSettingsOptions.cs #36920

merged 1 commit into from
Aug 31, 2023

Conversation

stephentoub
Copy link
Member

Avoid unnecessary overheads:

  • There's no need to get back a Match; it should just use IsMatch.
  • There's no need to create a StringBuilder on the success path.

@dotnet-bot dotnet-bot added this to the August 2023 milestone Aug 30, 2023
@IEvangelist IEvangelist enabled auto-merge (squash) August 31, 2023 12:29
@gewarren gewarren closed this Aug 31, 2023
auto-merge was automatically disabled August 31, 2023 18:06

Pull request was closed

@gewarren gewarren reopened this Aug 31, 2023
@gewarren gewarren enabled auto-merge (squash) August 31, 2023 18:06
@gewarren gewarren merged commit 34f4ae9 into main Aug 31, 2023
11 of 12 checks passed
@gewarren gewarren deleted the stephentoub-patch-1 branch August 31, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephentoub @IEvangelist @dotnet-bot @gewarren