Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify description for Roslyn formatting options #36927

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Unify description for Roslyn formatting options #36927

merged 1 commit into from
Aug 31, 2023

Conversation

FrediKats
Copy link
Contributor

@FrediKats FrediKats commented Aug 31, 2023 •
edited by github-actions bot
Loading

Summary

  • Remove \ for markdown headers (csharp\_new\_line\_before\_open_brace -> csharp_new_line_before_open_brace)
  • Fix formatting for row Introduced version - now has same length as other columns
  • Relace "Default value" with "Default option value" (same as all other rules in IDE* files)

Internal previews

馃搫 File 馃敆 Preview link
docs/fundamentals/code-analysis/style-rules/csharp-formatting-options.md C# formatting options
docs/fundamentals/code-analysis/style-rules/dotnet-formatting-options.md .NET formatting rules

@dotnet-bot dotnet-bot added this to the August 2023 milestone Aug 31, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Aug 31, 2023
gewarren
gewarren approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FrediKats

@gewarren gewarren closed this Aug 31, 2023
@gewarren gewarren reopened this Aug 31, 2023
@gewarren gewarren enabled auto-merge (squash) August 31, 2023 18:11
@gewarren gewarren merged commit a7da777 into dotnet:main Aug 31, 2023
13 of 14 checks passed
@FrediKats FrediKats deleted the unify-roslyn-formatting-option-page branch September 2, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FrediKats @gewarren @dotnet-bot