Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes GitHub issue #28103: Formatting guidelines: clarify how empty class, struct and interface declarations should be formatted #37860

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Fixes GitHub issue #28103: Formatting guidelines: clarify how empty class, struct and interface declarations should be formatted #37860

merged 1 commit into from
Nov 2, 2023

Conversation

v-thepet
Copy link
Contributor

@v-thepet v-thepet commented Nov 2, 2023 •
edited by github-actions bot
Loading

Summary

Fixes #28103

Updates article F# code formatting guidelines

Internal previews

📄 File 🔗 Preview link
docs/fsharp/style-guide/formatting.md F# code formatting guidelines

@v-thepet v-thepet requested review from KathleenDollard and a team as code owners November 2, 2023 01:04
@dotnet-bot dotnet-bot added this to the November 2023 milestone Nov 2, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Nov 2, 2023
BillWagner
BillWagner approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v-thepet

This LGTM. I'll :shipit: now.

@BillWagner BillWagner merged commit 4d8692e into dotnet:main Nov 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@KathleenDollard KathleenDollard Awaiting requested review from KathleenDollard KathleenDollard is a code owner

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fsharp/svc
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.

Formatting guidelines: clarify how empty class, struct and interface declarations should be formatted
3 participants
@v-thepet @BillWagner @dotnet-bot