Added file exception information to Directory.GetParent #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetrusha
changed the title
|
@rpetrusha it looks there is a typo and you mean PR #3971 |
|
Yes, I did, @pkulikov. Thanks for noticing it. I've fixed it in the description. |
mairaw
modified the milestones:
Sprint 130 (1/13/18 - 2/2/18),
Sprint 131 (2/3/18 - 2/23/18)
BillWagner
approved these changes
Feb 7, 2018
There was a problem hiding this comment.
@rpetrusha This LGTM. Once you are happy with this, go ahead and 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added file exception information to Directory.GetParent
Summary
This incorporated the actionable items from the discussion in PR #3971. I'll also open an issue to:
@JeremyKuhne, I've also revised the wording of the PathTooLongException; is this acceptable?
//cc @mriehm @mairaw @JeremyKuhne @pjanotti