New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix image problem + some editing #7777
Conversation
@CESARDELATORRE this still doesn't solve the image problem. Can I resize the images to make them fit better? |
Sure! No issues at all about re-sizing the images! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than resizing the image, @mairaw, this looks good. I'll approve and you can merge once the image is resized.
I'll try to fix it adding some responsiveness, so it fits better to the device's screen. |
@mairaw it's actually a css problem from the table the current markup generates, it can be solved with a little html/css and it would also be responsive, so the table would colapse to a single column for small devices. Is it ok to have html/css in docs? (ask because I saw the submitted one was removed) |
BTW, this markup is different from the original one, |
Hi @mairaw, I pushed the update to your branch because I'm about to end for the week, just in case you have the chance to test this before your day ends. Best, |
Thanks @mvelosop but that didn't fix the issue. See the page at https://review.docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/container-docker-introduction/docker-defined?branch=pr-en-us-7777. We avoid HTML as much as we can in the articles and I think resizing would probably be better in this case. |
Couldn't get to see the preview (unauthorized). 🙁 Anyway, resized the images and reverted to regular markdown. If this doesn't work we could just go to a two rows table, instead of a two column one. Best. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just resized the images to half size, this should fix it.
Yep, thanks @mvelosop! |
Fixes #7744