Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SmtpClient.xml #10010

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

David-Barrett-MS
Copy link

Summary

Remove reference to MailKit as we should not be recommending third party tools (it is up to the user to determine whether a third party tool is appropriate). We have also been receiving support cases for MailKit (because it is referred to in our docs).

Remove reference to MailKit as we should not be recommending third party tools (that is up to the user to determine).  We have also been receiving support cases for MailKit (because it is referred to in our docs).
@MihaZupan
Copy link
Member

We make similar recommendations in other places, e.g. https://github.com/dotnet/dotnet-api-docs/blob/main/includes%2Fdrawing.md#L12
How come MailKit is more problematic?

@David-Barrett-MS
Copy link
Author

David-Barrett-MS commented Jun 11, 2024 via email

@MihaZupan
Copy link
Member

MihaZupan commented Jun 11, 2024

The other examples I linked likewise include non Microsoft open source products.

If it's really needed, should we instead add clarifications that these are external projects? Removing helpful references from documentation seems counter productive.

@David-Barrett-MS
Copy link
Author

It isn't a helpful reference if it generates support cases for us, as it is not something we support. It seems to generate more problems than it solves, so I don't agree that it is a helpful reference. I've tested the library - it is not intuitive, and doesn't seem to work particularly well. If customers want to use it, that is their call - but we shouldn't be recommending it.

Copy link

Learn Build status updates of commit 374624e:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Mail/SmtpClient.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants