Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Math.Round interactive #1387

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Make Math.Round interactive #1387

merged 3 commits into from
Dec 19, 2018

Conversation

rpetrusha
Copy link

Make Math.Round interactive

This PR:

  • Makes the C# examples for the Math.Round, Math.Ceiling, and Math.Floor methods interactive.
  • Revises the Math.Round method to conform to the handling of overloaded methods on docs.microsoft.com.

Fixes #1136

@rpetrusha rpetrusha self-assigned this Dec 14, 2018
BillWagner
BillWagner approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @rpetrusha

I'll :shipit: now.

@BillWagner BillWagner merged commit 5b7b747 into dotnet:master Dec 19, 2018
@rpetrusha rpetrusha deleted the math.round branch January 25, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@rpetrusha rpetrusha

Labels
None yet
Projects
None yet
Milestone
Sprint 145 (11/26/2018 - 12/14/2018)
Development

Successfully merging this pull request may close these issues.
2 participants
@rpetrusha @BillWagner