Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Test new mdoc version #2773

Closed
wants to merge 1 commit into from
Closed

WIP Test new mdoc version #2773

wants to merge 1 commit into from

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 18, 2019

No description provided.

@mairaw mairaw requested review from TianqiZhang and joelmartinez and removed request for karelz, KathleenDollard, stevestein and scottaddie July 18, 2019 17:52
@mairaw
Copy link
Contributor Author

mairaw commented Jul 26, 2019

I'm guessing we'll have a new build once we have some of the fixes in. Should I close this PR now?

@joelmartinez
Copy link
Contributor

@mairaw I was originally planning on just running the subsequent preview release of mdoc (when it's ready) over this same branch without changes ... but I'm open to suggestions as to what would be best. I can easily run the next preview into a new branch. Which would you prefer?

@mairaw
Copy link
Contributor Author

mairaw commented Jul 26, 2019

It's up to you. But we have some major changes on master already since then (Preview 7 + removal of some assemblies) that might be hard to reconcile.

@joelmartinez
Copy link
Contributor

ahh ok ... yeah I see some conflicting files on the PR now. I'll put the new build into a new branch when it's ready :) That being said, I'll close this PR when that happens ... for now, I'm using it to make sure I address all your comments.

@joelmartinez
Copy link
Contributor

@mairaw, Closing this PR ... will have a new PR for you tomorrow :)

@mairaw
Copy link
Contributor Author

mairaw commented Jul 30, 2019

Cool!

@joelmartinez joelmartinez deleted the mdoc-dev-test3 branch August 7, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants