CI Update - .NET 8 Preview 6 #9140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=373330&view=results source_repo.branch:net8-pre6 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
ghost
assigned 
This comment was marked as outdated.
This comment was marked as outdated.
carlossanlop
approved these changes
Jul 13, 2023
|
Learn Build status updates of commit d5cbe21:
|
|
Learn Build status updates of commit 47d73e9:
|
|
Learn Build status updates of commit 4501c72:
|
gewarren
requested review from
a team,
RussKie,
merriemcgaw,
Rick-Anderson,
kouvel,
StephenMolloy,
HongGit,
mconnew,
AaronRobinsonMSFT,
jkoritzinsky,
cston,
333fred,
ajcvickers and
David-Engel
as code owners
|
Learn Build status updates of commit be21602: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
xml/Microsoft.Extensions.Hosting/HostOptions.xml
xml/Microsoft.Extensions.Http.AutoClient/BodyContentType.xml
xml/Microsoft.Extensions.Http.Telemetry.Metering/HttpRequestResultType.xml
xml/Microsoft.Extensions.Http.Telemetry/HttpRouteParameterRedactionMode.xml
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Learn Build status updates of commit 9421eb0:
|
|
Not sure if this comment is in the right place, but i don't know how to message someone on github or comment the page as there is no "provide feedback" option on it. I'm guessing it belongs here: Just a note on this page: The function AesGcm now requiring a Byte array with Keybytes AND a Tag size in bytes - this is not applicable for .NET 6 and earlier as they only need a Byte array with Keybytes to be created. The Tag + Nounce can be provided as parameters to the .Encrypt() and .Decrypt() methods. The requirement to add an Int32 with the size of the nounce is something new that i observed in .NET 8 () - so the documentation needs an update. ( i haven't tested it in .NET 7 because it's not LTS and i don't care about non-LTS releases) I really wonder why this change was necessary at all as it breaks some cryptographic code. The size of the Nounce is always automatically provided by passing a byte array to the methods. |
|
@ProIntegritate Thanks for the note. You can read about why the tag-less constructors were obsoleted in this issue: dotnet/docs#35338. I also created a PR to add that info to the SYSLIB0053 article. |
|
Thanks for reporting this, @ProIntegritate . opened an issue in the dotnet/runtime repo on your behalf so the System.Security area owners can take a look at this. dotnet/runtime#88933 If you wish to add some more info, or continue the conversation, please do so in that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=373330&view=results
source_repo.branch:net8-pre6
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
.NET 8 Preview 6
Fixes #9042.