Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker images should be based on Ubuntu images rather than Debian #6

Closed
MichaelSimons opened this issue Nov 18, 2015 · 5 comments
Closed

Docker images should be based on Ubuntu images rather than Debian #6

MichaelSimons opened this issue Nov 18, 2015 · 5 comments

Comments

@MichaelSimons
Copy link
Member

CLI tooling currently only supports Ubuntu therefore the base image for the dotnet docker images should be switched from Debian based to Ubuntu. (see https://github.com/dotnet/cli/issues/212)
@ahmetb
Copy link
Contributor

ahmetb commented Nov 18, 2015

If you're going to apply this fix, please make sure that the responsible team supports Debian as soon as possible.

In Docker land, Ubuntu is something mostly beginners use and not a common practice in production images. You can see almost all official Docker images (https://github.com/docker-library/) and our microsoft/aspnet image are based on Debian. Also read: http://mjg59.dreamwidth.org/36312.html

Although we can live with this I strongly advise against Ubuntu-based images unless there's a very good reason or they're going to be used as interactive development environments.

@Petermarcu
Copy link
Member

@ahmetalpbalkan, do you know how the aspnet images are built up?

@MichaelSimons
Copy link
Member Author

@Petermarcu, microsoft/aspnet they are based on Debian - debian:jessie

@ahmetalpbalkan, I agree with you, unfortunately CLI doesn't currently officially support Debian.

@ahmetb
Copy link
Contributor

ahmetb commented Nov 18, 2015

@Petermarcu I think I explained that in my earlier comment. :) If it's based on mono, then it is currently based on debian:wheezy. https://github.com/mono/docker/blob/master/4.0.5.1/Dockerfile

@Petermarcu
Copy link
Member

Thanks for the pointer to the dockerfile. This is working because they depend on mono. We don't have official coreclr support on Debian as of yet. Shouldn't be too far out though.

@MichaelSimons MichaelSimons mentioned this issue Nov 19, 2015
Merged
@MichaelSimons MichaelSimons mentioned this issue Nov 19, 2015
Closed
MichaelSimons added a commit that referenced this issue May 22, 2018
@MichaelSimons
# This is a combination of 6 commits.
977ada1 
# This is the 1st commit message:

Fixups for merging into nightly

# The commit message #2 will be skipped:

# Update nightly SDK to 2.1.300-rtm-008823 (#519)
#

# The commit message #3 will be skipped:

# Update nightly SDK to 2.1.300-rtm-008823 (#538)
#

# The commit message #4 will be skipped:

# Remove 2.0-arm preview images (#537)
#

# The commit message #5 will be skipped:

# Update nightly SDK to 2.1.300-rtm-008838 (#539)
#

# The commit message #6 will be skipped:

# Update nightly SDK to 2.1.300-rtm-008866 (#542)
#
MichaelSimons added a commit that referenced this issue Jan 22, 2019
@MichaelSimons
# This is a combination of 7 commits.
8851157 
# This is the 1st commit message:

Move nightly images to MCR

# The commit message #2 will be skipped:

# Build changes

# The commit message #3 will be skipped:

# WIP

# The commit message #4 will be skipped:

# Build tweaks

# The commit message #5 will be skipped:

# Test updates

# The commit message #6 will be skipped:

# tweaks

# The commit message #7 will be skipped:

# Update image-builder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ahmetb @Petermarcu @MichaelSimons