Support localization in sdk for Alpine 3.16 #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richlander
approved these changes
Jun 15, 2022
| @@ -18,7 +18,7 @@ ENV \ | |||
| POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetCoreSDK-Alpine-3.16 | |||
|
|
|||
| # Add dependencies for disabling invariant mode (set in base image) | |||
| RUN apk add --no-cache icu-libs | |||
| RUN apk add --no-cache icu-data-full icu-libs | |||
There was a problem hiding this comment.
Nit - the formatting here is not consistent. Multi-package installs should use separate lines. I would be fine with multi-lines being the standard even when a single package is installed.
MichaelSimons
approved these changes
Jun 16, 2022
This was referenced Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3844
This ensures that the
icu-data-fullpackage is included by default in the sdk image for Alpine 3.16.To better catch when localization scenarios fail in the sdk image, I've added a test which will run
dotnet teston a unit test project from within an sdk container. This is just a simple .cs file that we can add more test cases to as necessary.