Refactor update-dependencies to support additional scenarios #469
Conversation
| private static readonly string s_varShaPattern = | ||
| $"[ \\$](?<{EnvNameGroupName}>(dotnet_|aspnetcore_)sha512)( )*=( )*'(?<{ValueGroupName}>[^'\\s]*)'"; | ||
|
|
||
| private static readonly Regex s_downloadUrlRegex = new Regex($"({s_envDownloadUrlPattern})|{s_inlineUrlPattern}"); |
There was a problem hiding this comment.
Unfortunate that GitHub's code coloring doesn't like that s_varShaPattern string. 😕 Not sure what's exactly causing it to break.
There was a problem hiding this comment.
I had noticed that :(
There was a problem hiding this comment.
If I don't put it on a separate line, the syntax coloring works...
There was a problem hiding this comment.
I wonder if this is by chance related to the same underlying cause as atom/language-csharp#113? Sounds like work is in play to get GH to use a more recent version of the grammar. Will monitor.
There was a problem hiding this comment.
FYI, GitHub has just released and that issue along with many others around C# syntax highlighting are fixed 🎉
There was a problem hiding this comment.
Thanks for the heads up @kasper3!
| downloadUrl = SubstituteEnvRef(downloadUrl, versionInfo.EnvName, versionInfo.Version); | ||
| sha = await GetDotNetCliChecksumsShaAsync(downloadUrl, versionInfo.EnvName) | ||
| ?? await GetDotNetReleaseChecksumsShaAsync(downloadUrl, versionInfo.EnvName, versionInfo.Version); | ||
| sha = sha?.ToLower(); |
| { | ||
| Trace.TraceInformation($"Failed to find `dotnetclichecksums` sha"); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Unnecessary semicolon (and more later on other usings).
| syntax.DefineParameter( | ||
| "build-info", | ||
| ref buildInfoUrl, | ||
| (value) => new Uri(value), | ||
| "URL of the build info to update the Dockerfiles with"); |
There was a problem hiding this comment.
Worthwhile to call out here that file:// works?
https://dotnetcli.blob.core.windows.net/dotnet/checksumsif not found inhttps://dotnetclichecksums.blob.core.windows.net@dotnet-bot skip ci please