Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Composite Docker Images for Jammy Chiseled and Mariner Distroless #4710

Merged
merged 20 commits into from
Jul 12, 2023
Merged

Enable Composite Docker Images for Jammy Chiseled and Mariner Distroless #4710

merged 20 commits into from
Jul 12, 2023

Conversation

ivdiazsa
Copy link
Member

This PR is a follow-up to #4594. Now, we're looking to also build the Jammy Chiseled and Mariner Distroless flavors of the composite.

@ivdiazsa
Copy link
Member Author

@lbussell @mangod9 @trylek

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ivan for pulling this off! The change looks good to my limited understanding but I'd definitely welcome docker people to take a closer look at the various details, I'm not really that much familiar with the template system. Please also rebase your change against the latest main, in the current form your PR shows as blocked on conflicts and cannot be merged in.

@mangod9
Copy link
Member

mangod9 commented Jun 30, 2023

yeah would be good to get a review from @lbussell, @mthalman et. al. @richlander fyi.

@richlander
Copy link
Member

Thanks!

Do you have size diffs to share?

@mangod9
Copy link
Member

mangod9 commented Jun 30, 2023

Thanks!

Do you have size diffs to share?

should be an absolute ~9mb reduction for x64 and ~12mb for arm64.

@richlander
Copy link
Member

Nice @mangod9 ... Can one of you add that context to the initial PR comment so that it is obvious?

@ivdiazsa
Copy link
Member Author

Something might have gone wrong with the updating with the nightly branch. Looking at it now

@mthalman
Copy link
Member

I just merged what should be the last update for Preview 6. So you'll need to merge changes from nightly again and update the SHAs for the composite files in the manifest.versions.json, based on that new build. Then also regenerate Dockerfiles.

@lbussell
Copy link
Contributor

lbussell commented Jul 1, 2023

When the PR is green again I can queue an internal build and update the baseline here. Nice job on the templates @ivdiazsa.

manifest.json Outdated Show resolved Hide resolved
@lbussell lbussell requested a review from mthalman July 6, 2023 17:54
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're so close to Preview 6 release, we'll get this shipped in Preview 7. So let's hold off on merging this into nightly until after the Preview 6 release just to minimize the management of diffs between the branches.

@mangod9
Copy link
Member

mangod9 commented Jul 12, 2023

@mthalman just checking if the preview6 release is done, so we could get this merged?

@mthalman mthalman merged commit 0d8f647 into dotnet:nightly Jul 12, 2023
99 checks passed
@mangod9
Copy link
Member

mangod9 commented Jul 12, 2023

Thanks Matt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants