-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Composite Docker Images for Jammy Chiseled and Mariner Distroless #4710
Enable Composite Docker Images for Jammy Chiseled and Mariner Distroless #4710
Conversation
…eady, if not for the lack of shell in distroless images.
going to use them for the time being.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ivan for pulling this off! The change looks good to my limited understanding but I'd definitely welcome docker people to take a closer look at the various details, I'm not really that much familiar with the template system. Please also rebase your change against the latest main, in the current form your PR shows as blocked on conflicts and cannot be merged in.
yeah would be good to get a review from @lbussell, @mthalman et. al. @richlander fyi. |
Thanks! Do you have size diffs to share? |
src/aspnet/8.0/cbl-mariner2.0-distroless-composite/amd64/Dockerfile
Outdated
Show resolved
Hide resolved
src/aspnet/8.0/cbl-mariner2.0-distroless-composite/amd64/Dockerfile
Outdated
Show resolved
Hide resolved
should be an absolute ~9mb reduction for x64 and ~12mb for arm64. |
Nice @mangod9 ... Can one of you add that context to the initial PR comment so that it is obvious? |
Something might have gone wrong with the updating with the nightly branch. Looking at it now |
I just merged what should be the last update for Preview 6. So you'll need to merge changes from nightly again and update the SHAs for the composite files in the manifest.versions.json, based on that new build. Then also regenerate Dockerfiles. |
When the PR is green again I can queue an internal build and update the baseline here. Nice job on the templates @ivdiazsa. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're so close to Preview 6 release, we'll get this shipped in Preview 7. So let's hold off on merging this into nightly until after the Preview 6 release just to minimize the management of diffs between the branches.
@mthalman just checking if the preview6 release is done, so we could get this merged? |
Thanks Matt! |
This PR is a follow-up to #4594. Now, we're looking to also build the Jammy Chiseled and Mariner Distroless flavors of the composite.