-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup ends up with entries with different state managers in DbContext Pooling #11311
Labels
area-test
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
Milestone
Comments
Note for implementer: I suspect this is because events are not be unscribed when the services are reset. |
Investigated this and found that it is a test infra issue, so moving out of 2.1. The test fixture obtains the context from the pool, but then disposes of it in the normal way instead of returning it to the pool. |
AndriySvyryd
added a commit
that referenced
this issue
May 24, 2018
AndriySvyryd
added a commit
that referenced
this issue
May 24, 2018
AndriySvyryd
added
the
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
label
Jun 6, 2018
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Jul 22, 2018
* Switch to PoolableDbContext in various tests (dotnet/efcore#11311) * Test for MinBatchSize (dotnet/efcore#10091)
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Aug 3, 2018
* Switch to PoolableDbContext in various tests (dotnet/efcore#11311) * Test for MinBatchSize (dotnet/efcore#10091)
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Aug 10, 2018
* Switch to PoolableDbContext in various tests (dotnet/efcore#11311) * Test for MinBatchSize (dotnet/efcore#10091)
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Aug 10, 2018
* Switch to PoolableDbContext in various tests (dotnet/efcore#11311) * Test for MinBatchSize (dotnet/efcore#10091)
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Aug 12, 2018
* Switch to PoolableDbContext in various tests (dotnet/efcore#11311) * Test for MinBatchSize (dotnet/efcore#10091)
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Aug 12, 2018
* Switch to PoolableDbContext in various tests (dotnet/efcore#11311) * Test for MinBatchSize (dotnet/efcore#10091)
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Aug 12, 2018
* Switch to PoolableDbContext in various tests (dotnet/efcore#11311) * Test for MinBatchSize (dotnet/efcore#10091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-test
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
https://github.com/aspnet/EntityFrameworkCore/blob/2bdb72f0206ef0f4657f565b5a5bf7226564befc/src/EFCore.Specification.Tests/GraphUpdatesFixtureBase.cs#L29
Enable pooling with above line.
Some tests fail.
I investigated in Optional_many_to_one_dependents_with_alternate_key_are_orphaned_starting_detached test for (ChangedNotifications : GraphUpdatesSqliteTestBase<ChangedNotifications.ChangedNotificationsFixture>)
Test remove dependent from one of the collection of the root. After save changes during fixup, while removing entity from root's collection when it fire CollectionChanged event, but the entity entry handling the event is incorrect entry and has StateManager from previous state. Since both of them have different NavigationFixer, we removing both sides of navigations (instead of just from parent to child).
Need to investigate more.
The text was updated successfully, but these errors were encountered: