Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store IsLoaded flags in proxy for better lazy-loading experience #12780

Closed
ajcvickers opened this issue Jul 24, 2018 · 0 comments
Closed

Store IsLoaded flags in proxy for better lazy-loading experience #12780

ajcvickers opened this issue Jul 24, 2018 · 0 comments
Assignees
@ajcvickers
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

We currently need to access the state entry to know whether or not a property is loaded. This is problematic when an entity is not tracked or not loaded, since there is no state entry that can be (safely) accessed. Instead, when using proxies the IsLoaded state could be stored in the proxy, so we we know, for example, whether the navigation is loaded already (even if null/empty) and can avoid throwing.
This was referenced Jul 24, 2018
Closed
Closed
@ajcvickers ajcvickers self-assigned this Jul 27, 2018
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jul 27, 2018
ajcvickers added a commit that referenced this issue Feb 18, 2019
@ajcvickers
Store IsLoaded state in lazy-loading proxies
e29dc76 
Issue #12780

Main changes:
* Make ILazyLoader a transient service and create one per entity
* Add API to set IsLoaded state in ILazyLoader
* Call back into any ILazyLoader service property when setting loaded state
* Ensure that IsLoaded is called, even when doing no-tracking Include queries
@ajcvickers ajcvickers mentioned this issue Feb 18, 2019
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 18, 2019
ajcvickers added a commit that referenced this issue Feb 23, 2019
@ajcvickers
Store IsLoaded state in lazy-loading proxies
9f63cba 
Issue #12780

Main changes:
* Make ILazyLoader a transient service and create one per entity
* Add API to set IsLoaded state in ILazyLoader
* Call back into any ILazyLoader service property when setting loaded state
* Ensure that IsLoaded is called, even when doing no-tracking Include queries
ajcvickers added a commit that referenced this issue Feb 28, 2019
@ajcvickers
Store IsLoaded state in lazy-loading proxies
40569c9 
Issue #12780

Main changes:
* Make ILazyLoader a transient service and create one per entity
* Add API to set IsLoaded state in ILazyLoader
* Call back into any ILazyLoader service property when setting loaded state
* Ensure that IsLoaded is called, even when doing no-tracking Include queries
@Bitz Bitz mentioned this issue Mar 27, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview4 Apr 15, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview4, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajcvickers ajcvickers

Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@ajcvickers