Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store IsLoaded state in lazy-loading proxies #14733

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

ajcvickers
Copy link
Member

Issue #12780

Main changes:

  • Make ILazyLoader a transient service and create one per entity
  • Add API to set IsLoaded state in ILazyLoader
  • Call back into any ILazyLoader service property when setting loaded state
  • Ensure that IsLoaded is called, even when doing no-tracking Include queries

@smitpatel
Copy link
Member

I would lean on the side of calling LazyLoader.IsLoaded directly from query rather than creating the entityentry and then forgeting it.

Issue #12780

Main changes:
* Make ILazyLoader a transient service and create one per entity
* Add API to set IsLoaded state in ILazyLoader
* Call back into any ILazyLoader service property when setting loaded state
* Ensure that IsLoaded is called, even when doing no-tracking Include queries
@ajcvickers
Copy link
Member Author

@smitpatel New version up.

Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ajcvickers ajcvickers merged commit 40569c9 into master Feb 28, 2019
@smitpatel smitpatel deleted the IShouldaTriedHarder0216 branch March 13, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants