Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Data.Sqlite: Add Span overloads to SqliteBlob #16187

Closed
Tracked by #22949
bricelam opened this issue Jun 21, 2019 · 0 comments · Fixed by #24503
Closed
Tracked by #22949

Microsoft.Data.Sqlite: Add Span overloads to SqliteBlob #16187

bricelam opened this issue Jun 21, 2019 · 0 comments · Fixed by #24503
Assignees
@bricelam
Labels
area-adonet-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. type-enhancement
Milestone
6.0.0

Comments

@bricelam
Copy link
Contributor

SQLitePCL.raw v2 adds a lot of Span goodness. We could add implementation to these methods, but it may require us to target .NET Standard 2.1.

public class SqliteBlob : Stream {
    public override int Read(Span<byte> buffer);
    public override void Write(ReadOnlySpan<byte> buffer);
}
@bricelam bricelam self-assigned this Jun 21, 2019
@bricelam bricelam mentioned this issue Jun 22, 2019
Merged
@ajcvickers ajcvickers added this to the Backlog milestone Jun 24, 2019
@ajcvickers ajcvickers mentioned this issue Oct 10, 2020
Open
16 tasks
@bricelam bricelam added the good first issue This issue should be relatively straightforward to fix. label Mar 23, 2021
bricelam added a commit to bricelam/efcore that referenced this issue Mar 24, 2021
@bricelam
Microsoft.Data.Sqlite: Add Span overloads to SqliteBlob
51e69f4 
Fixes dotnet#16187
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 24, 2021
@bricelam bricelam modified the milestones: Backlog, 6.0.0 Mar 24, 2021
@bricelam bricelam mentioned this issue Mar 24, 2021
Merged
bricelam added a commit to bricelam/efcore that referenced this issue Mar 25, 2021
@bricelam
Microsoft.Data.Sqlite: Add Span overloads to SqliteBlob
08be92c 
Fixes dotnet#16187
@ghost ghost closed this as completed in #24503 Mar 25, 2021
ghost pushed a commit that referenced this issue Mar 25, 2021
@bricelam
Microsoft.Data.Sqlite: Add Span overloads to SqliteBlob (#24503)
02575b3 
Fixes #16187
@bricelam bricelam modified the milestones: 6.0.0, 6.0.0-preview4 Mar 26, 2021
@ajcvickers ajcvickers mentioned this issue May 27, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview4, 6.0.0 Nov 8, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-adonet-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Microsoft.Data.Sqlite: Add Span overloads to SqliteBlob bricelam/efcore
2 participants
@bricelam @ajcvickers