Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SQLitePCL.raw to 2.0.0 #16189

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Update SQLitePCL.raw to 2.0.0 #16189

merged 1 commit into from
Jun 25, 2019

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Jun 21, 2019

Filed #16187 and #16202 to take more advantage of the new Span overloads.

Resolves #14824

@bricelam bricelam requested a review from dougbu as a code owner June 21, 2019 04:07
eng/Versions.props Outdated Show resolved Hide resolved
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+OSS approvals probably

@bricelam
Copy link
Contributor Author

@ericsink Looks like the SQLite tests deadlock. I'll investigate more...

@ericsink
Copy link

That's unfortunate.

Let me know if there is a way I can help.

@bricelam
Copy link
Contributor Author

@ericsink The string overload of sqlite2_prepare_v2 sets tail to "\0" instead of "". Our prepare-and-execute loop never ends.

@ericsink
Copy link

@bricelam Ouch. Sorry about that.

Well at least it'll be an easy fix. Much easier than I was expecting once the word "deadlock" appeared.

@bricelam

This comment has been minimized.

@bricelam

This comment has been minimized.

@bricelam
Copy link
Contributor Author

One last failure (of 11,730 tests). I'll investigate. Could be a SQLite bug...

Expected: ALFKI
  Actual: (null)

@smitpatel
Copy link
Member

Couldn't see anything obviously wrong with the translation for that test.

@bricelam
Copy link
Contributor Author

bricelam commented Jun 24, 2019

It's a SQLite bug. Results are different in 3.28.0 (repros without e_sqlite3)

SELECT (
    SELECT "t"."CustomerID"
    FROM (
        SELECT "o"."CustomerID", "o"."OrderDate"
        FROM "Orders" AS "o"
        WHERE ("c"."CustomerID" = "o"."CustomerID") AND "o"."CustomerID" IS NOT NULL
        ORDER BY "o"."CustomerID", "o"."OrderDate" DESC
        LIMIT 2
    ) AS "t"
    ORDER BY "t"."CustomerID", "t"."OrderDate" DESC
    LIMIT 1)
FROM "Customers" AS "c";

@ericsink
Copy link

ericsink commented Jun 25, 2019

@bricelam A new prerelease of SQLitePCLRaw has been pushed up to nuget.org, with fixes for:

ericsink/SQLitePCL.raw#274
ericsink/SQLitePCL.raw#275
ericsink/SQLitePCL.raw#276

@bricelam bricelam merged commit 9b0d6e0 into dotnet:master Jun 25, 2019
@bricelam bricelam deleted the raw branch June 25, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to SQLitePCL.raw v2
4 participants