-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update external dependencies to latest GA releases #17482
Comments
/cc @AndriySvyryd for Cosmos (We don't necessarily have to update, but if there are newer RTM packages we might want to update.) Thanks @JunTaoLuo for identifying these |
/cc @Pilchie FYI |
Cosmos is already at 3.0.0 https://github.com/aspnet/EntityFrameworkCore/blob/release/3.0/eng/Versions.props#L15 |
@AndriySvyryd Right, but there is a 3.1.1 package now. |
I'm not sure we should upgrade unless we need to, users can always bump it up manually. |
@AndriySvyryd Can you try to find out what they fixed between 3.0 and 3.1.1? There might be critical issues that we should update for. |
System.Threading.Tasks.Extensions is for downlevel ValueTask. We can dump it. |
@bricelam Is it breaking to remove the reference in 3.1, or would it be a no-op anyway? |
The current package actually looks like it will break .NET Standard 2.1 projects. We should remove it in 3.0 |
Here's the changelog: https://github.com/Azure/azure-cosmos-dotnet-v3/blob/releases/3.1.1/changelog.md |
@AndriySvyryd Thanks. Given where we are, I agree we stay with 3.0 here. Test coverage is not as good as for other providers. |
@bricelam Looks like our Castle.Core is quite old; given that it only impacts proxies and test coverage is pretty good I think we should update this for 3.0 as well. Thoughts? |
@bricelam So you think we should or should not update our Castle reference? |
Oh, lol. Either way--it's low risk and low value. 😉 |
@bricelam I read through the release notes in more detail. Let's leave as is for now, but we should update for 3.1 or at the latest |
Our analyzer depends on Microsoft.CodeAnalysis.CSharp.Workspaces. Is it safe to update this package? We really only need to work with the version of Roslyn that ships in VS2019 16.3 and the .NET Core 3.0 SDK, right? (3.3.0) |
Filed #17625 |
System.Threading.Tasks.Extensions (4.5.2)https://github.com/aspnet/EntityFrameworkCore/blob/release/3.0/src/EFCore/EFCore.csproj#L27
Castle.Core (4.2.1)
https://github.com/aspnet/EntityFrameworkCore/blob/release/3.0/src/EFCore.Proxies/EFCore.Proxies.csproj#L19
Microsoft.Azure.Cosmos (3.0.0)
https://github.com/aspnet/EntityFrameworkCore/blob/release/3.0/src/EFCore.Cosmos/EFCore.Cosmos.csproj#L25
SQLitePCLRaw (2.0.1)
The text was updated successfully, but these errors were encountered: