Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the non-thread-safety of DbContext more visible #23319

Closed
roji opened this issue Oct 9, 2019 · 1 comment · Fixed by #25516
Closed

Make the non-thread-safety of DbContext more visible #23319

roji opened this issue Oct 9, 2019 · 1 comment · Fixed by #25516
Labels
area-dbcontext area-docs closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@roji
Copy link
Member

roji commented Oct 9, 2019

We already have a paragraph on this in the "Configuring a DbContext" page, but this may not be enough (e.g. see #18148).

Could be part of a general rethinking of fundamentals/getting started (dotnet/EntityFramework.Docs#1726). The non-safety is definitely "getting started" information we want to surface to new users right away.

Also maybe add thread-safety notes into our API documentation, which seems pretty common in .NET in general?

@ajcvickers ajcvickers self-assigned this Jan 15, 2020
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 9, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 10, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 10, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 10, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 10, 2020
Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 11, 2020
Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling

New docs for context creation and initialization
ajcvickers referenced this issue in dotnet/EntityFramework.Docs Nov 11, 2020
New docs for context creation and initialization

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling
@ajcvickers
Copy link
Member

Note from triage: in the conceptual docs now; also add to API docs for DbContext.

@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 14, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 17, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc1, 6.0.0 Nov 8, 2021
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dbcontext area-docs closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants