Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EFCore will break on Net6 cause Queryable class will be extended and EF Core Reflection will break #24002

Closed
jogibear9988 opened this issue Jan 27, 2021 · 5 comments · Fixed by #24090
Closed

EFCore will break on Net6 cause Queryable class will be extended and EF Core Reflection will break #24002

jogibear9988 opened this issue Jan 27, 2021 · 5 comments · Fixed by #24090
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported Servicing-approved type-bug
Milestone
3.1.14

Comments

@jogibear9988
Copy link

EFCore reflection will break when this Issue is fixed and will be merged into NET6

dotnet/runtime#28776

Problem is EFCore only checks for Parameter count and uses "Single", so it will crash cause there will be now 2 Methods with same Parameter Count:

efcore/src/EFCore/Query/QueryableMethods.cs

Line 477 in 5d53796

ElementAt = queryableMethods.Single(

EFCore should switch to a safer reflection like done in Linq2db:
https://github.com/linq2db/linq2db/blob/37d0f108214c2fc0e6f1991c9d08627c605a9241/Source/LinqToDB/Reflection/Methods.cs#L42
or in NHibernate
https://github.com/nhibernate/nhibernate-core/blob/master/src/NHibernate/Util/ReflectionCache.cs
@smitpatel smitpatel self-assigned this Jan 28, 2021
@eiriktsarpalis
Copy link
Member

Related to #23996.

@roji
Copy link
Member

roji commented Jan 28, 2021

Unless I'm mistaken, this should also be backported otherwise older EF running on newer BCLs would also break...

@jogibear9988
Copy link
Author

@roji yes, all versions without propper fix will not work on net6.
I think not only ElementAt should be fixed, all reflection code for method finding should be changed to be more stable (compare parameter types, not only count)

@ajcvickers
Copy link
Member

Notes from triage: @smitpatel to follow up on:

  • Which releases of EF Core are broken
  • Whether or not EF6 is broken

@AndriySvyryd AndriySvyryd added this to the 5.0.x milestone Feb 5, 2021
smitpatel added a commit that referenced this issue Feb 8, 2021
@smitpatel
Query: Use stronger reflection in Queryable/Enumerable methods
7f8a1f9 
Resolves #24002
@smitpatel smitpatel mentioned this issue Feb 8, 2021
Merged
smitpatel added a commit that referenced this issue Feb 8, 2021
@smitpatel
Query: Use stronger reflection in Queryable/Enumerable methods
352cdf2 
Resolves #24002
smitpatel added a commit that referenced this issue Feb 10, 2021
@smitpatel
Query: Use stronger reflection in Queryable/Enumerable methods (#24090)
acfee51 
Resolves #24002
smitpatel added a commit that referenced this issue Feb 10, 2021
@smitpatel
Query: Use stronger reflection in Queryable/Enumerable methods (#24090)
77460f8 
Resolves #24002
@smitpatel smitpatel mentioned this issue Feb 10, 2021
Merged
smitpatel added a commit that referenced this issue Feb 10, 2021
@smitpatel
Query: Use stronger reflection in Queryable/Enumerable methods
50a34bd 
Resolves #24002
@smitpatel smitpatel mentioned this issue Feb 10, 2021
Merged
@smitpatel smitpatel reopened this Feb 10, 2021
@smitpatel
Copy link
Member

PRs out for 3.1/5.0

@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 10, 2021
wtgodbe pushed a commit that referenced this issue Mar 10, 2021
@smitpatel
Query: Use stronger reflection in Queryable/Enumerable methods (#24090)…
8fbe0c3 
… (#24115)

Resolves #24002
smitpatel added a commit that referenced this issue Mar 10, 2021
@smitpatel
[release/5.0] Query: Use stronger reflection in Queryable/Enumerable …
fbe40a1 
…methods (#24116)

Resolves #24002
@ajcvickers ajcvickers modified the milestones: 5.0.x, 3.1.14 Mar 11, 2021
This was referenced Mar 16, 2021
Closed
Closed
This was referenced Mar 22, 2021
Closed
Closed
@smitpatel smitpatel mentioned this issue Nov 11, 2021
Closed
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue Jan 22, 2022
Closed
1 task
@ajcvickers ajcvickers mentioned this issue Jun 8, 2022
Closed
@roji roji mentioned this issue Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported Servicing-approved type-bug
Projects
None yet
Milestone
3.1.14
Development

Successfully merging a pull request may close this issue.

Query: Use stronger reflection in Queryable/Enumerable methods dotnet/efcore
6 participants
@jogibear9988 @ajcvickers @smitpatel @roji @eiriktsarpalis @AndriySvyryd