Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move table configuration methods to (OwnedNavigation)TableBuilder #28205

Closed
3 tasks done
AndriySvyryd opened this issue Jun 11, 2022 · 5 comments · Fixed by #28630
Closed
3 tasks done

Move table configuration methods to (OwnedNavigation)TableBuilder #28205

AndriySvyryd opened this issue Jun 11, 2022 · 5 comments · Fixed by #28630
Labels
area-model-building breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
7.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Jun 11, 2022 •
edited
Loading

  • HasComment
  • HasCheckConstraint
  • IsMemoryOptimized
@ajcvickers ajcvickers added this to the 7.0.0 milestone Jun 15, 2022
@ajcvickers
Copy link
Member

Note from triage: Obsolete existing methods.

@roji
Copy link
Member

roji commented Jun 15, 2022

Thinking about this again, maybe it's OK to leave the current methods on EntityTypeBuilder as easy sugar for when you don't map to multiple tables (which is the majority case, after all)... Would also avoid the obsoletion/breaking change...

@AndriySvyryd
Copy link
Member Author

These methods only apply to tables and if we leave them they could me misinterpreted as somehow applicable to views/functions/sprocs

@roji
Copy link
Member

roji commented Jun 15, 2022

Comment specifically could actually work on those other things. For the other two, throwing if they're applied on a non-table could be reasonable - just to provide the shortcut and prevent the break. But am OK for removal if there are strong feelings here.

@AndriySvyryd
Copy link
Member Author

Comment specifically could actually work on those other things.

Yes, hence the confusion since it won't be applied

@AndriySvyryd AndriySvyryd mentioned this issue Aug 8, 2022
Closed
4 tasks
AndriySvyryd added a commit that referenced this issue Aug 9, 2022
@AndriySvyryd
Move table configuration methods to (OwnedNavigation)TableBuilder
61b0a35 
ConventionsBuilder -> ConventionSetBuilder
AreRowsAffectedReturned -> IsRowsAffectedReturned
IStoreStoredProcedureReturn -> IStoreStoredProcedureReturnValue

Fixes #28205
@AndriySvyryd AndriySvyryd removed their assignment Aug 9, 2022
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 9, 2022
@AndriySvyryd AndriySvyryd mentioned this issue Aug 9, 2022
Merged
AndriySvyryd added a commit that referenced this issue Aug 9, 2022
@AndriySvyryd
Move table configuration methods to (OwnedNavigation)TableBuilder
3f362f2 
ConventionsBuilder -> ConventionSetBuilder
AreRowsAffectedReturned -> IsRowsAffectedReturned
IStoreStoredProcedureReturn -> IStoreStoredProcedureReturnValue

Fixes #28205
AndriySvyryd added a commit that referenced this issue Aug 9, 2022
@AndriySvyryd
Move table configuration methods to (OwnedNavigation)TableBuilder
0b57955 
ConventionsBuilder -> ConventionSetBuilder
AreRowsAffectedReturned -> IsRowsAffectedReturned
IStoreStoredProcedureReturn -> IStoreStoredProcedureReturnValue

Fixes #28205
@AndriySvyryd AndriySvyryd mentioned this issue Aug 9, 2022
Closed
AndriySvyryd added a commit that referenced this issue Aug 9, 2022
@AndriySvyryd
Move table configuration methods to (OwnedNavigation)TableBuilder
712e764 
ConventionsBuilder -> ConventionSetBuilder
AreRowsAffectedReturned -> IsRowsAffectedReturned
IStoreStoredProcedureReturn -> IStoreStoredProcedureReturnValue

Fixes #28205
AndriySvyryd added a commit that referenced this issue Aug 9, 2022
@AndriySvyryd
Move table configuration methods to (OwnedNavigation)TableBuilder
96a7d4b 
ConventionsBuilder -> ConventionSetBuilder
AreRowsAffectedReturned -> IsRowsAffectedReturned
IStoreStoredProcedureReturn -> IStoreStoredProcedureReturnValue

Fixes #28205
@ghost ghost closed this as completed in #28630 Aug 9, 2022
ghost pushed a commit that referenced this issue Aug 9, 2022
@AndriySvyryd
Move table configuration methods to (OwnedNavigation)TableBuilder (#2…
630edd1 
…8630)

ConventionsBuilder -> ConventionSetBuilder
AreRowsAffectedReturned -> IsRowsAffectedReturned
IStoreStoredProcedureReturn -> IStoreStoredProcedureReturnValue

Fixes #28205
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-rc1 Aug 12, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-rc1, 7.0.0 Nov 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Move table configuration methods to (OwnedNavigation)TableBuilder dotnet/efcore
3 participants
@ajcvickers @roji @AndriySvyryd