Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move table configuration methods to (OwnedNavigation)TableBuilder #28630

Merged
1 commit merged into from
Aug 9, 2022
Merged

Conversation

AndriySvyryd
Copy link
Member

ConventionsBuilder -> ConventionSetBuilder
AreRowsAffectedReturned -> IsRowsAffectedReturned
IStoreStoredProcedureReturn -> IStoreStoredProcedureReturnValue

Fixes #28205

@AndriySvyryd AndriySvyryd requested a review from a team August 9, 2022 00:11
@AndriySvyryd AndriySvyryd force-pushed the Issue28205 branch 2 times, most recently from 3f362f2 to 0b57955 Compare August 9, 2022 04:02
@ghost
Copy link

ghost commented Aug 9, 2022

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 9, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

ConventionsBuilder -> ConventionSetBuilder
AreRowsAffectedReturned -> IsRowsAffectedReturned
IStoreStoredProcedureReturn -> IStoreStoredProcedureReturnValue

Fixes #28205
@ghost
Copy link

ghost commented Aug 9, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit 630edd1 into main Aug 9, 2022
@ghost ghost deleted the Issue28205 branch August 9, 2022 20:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move table configuration methods to (OwnedNavigation)TableBuilder
2 participants