Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HierarchyId: Don't go through SqlBytes #30305

Closed
bricelam opened this issue Feb 17, 2023 · 0 comments · Fixed by #30588
Closed

HierarchyId: Don't go through SqlBytes #30305

bricelam opened this issue Feb 17, 2023 · 0 comments · Fixed by #30588
Assignees
@bricelam
Labels
area-hierarchyid closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
8.0.0

Comments

@bricelam
Copy link
Contributor

We should be able to avoid going through SqlBytes when reading and writing values and just go through SqlHierarchyId directly now.
@ajcvickers ajcvickers added this to the MQ milestone Mar 2, 2023
bricelam added a commit to bricelam/efcore that referenced this issue Mar 27, 2023
@bricelam
HierarchyId: Address API Review feedback
5b7f32d 
Changes:
- Make HierarchyId compatible with System.Text.Json (resolves efcore/EFCore.SqlServer.HierarchyId#40)
- Add HierarchyId constructors
- Add overloads and clarify docs for GetDescendant
- Improve interop with SqlHierarchyId
- Translate calls on constants (fixes dotnet#30307)
- Don't go through SqlBytes (resolves dotnet#30305)

Part of dotnet#30306
@bricelam bricelam mentioned this issue Mar 27, 2023
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 27, 2023
@bricelam bricelam self-assigned this Mar 27, 2023
@bricelam bricelam modified the milestones: MQ, 8.0.0 Mar 27, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0, 8.0.0-preview4 Apr 20, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0-preview4, 8.0.0 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-hierarchyid closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

HierarchyId: Address API Review feedback bricelam/efcore
2 participants
@bricelam @ajcvickers