HierarchId: Cannot call methods on varchar

[bricelam]

When calling a method on a constant hierarchyid value...

var query = from p in _db.Patriarchy
            where HierarchyId.Parse("/1/").IsDescendantOf(p.Id)
            select p.Name;

...we generate a text literal and try to call an instance method on it...

SELECT [p].[Name]
FROM [Patriarchy] AS [p]
WHERE '/1/'.IsDescendantOf([p].[Id])

...which results in an error.

SqlException : Cannot call methods on varchar.

Instead, we should generate a hierarchyid value.

SELECT [p].[Name]
FROM [Patriarchy] AS [p]
WHERE hierarchyid::Parse('/1/').IsDescendantOf([p].[Id])

The spatial extension handles this by always generating fully-qualified literals...

efcore/src/EFCore.SqlServer.NTS/Storage/Internal/SqlServerGeometryTypeMapping.cs

Lines 84 to 99 in c94a821

	builder
	.Append(_isGeography ? "geography" : "geometry")
	.Append("::")
	.Append(defaultSrid ? "Parse" : "STGeomFromText")
	.Append("('")
	.Append(WKTWriter.ForMicrosoftSqlServer().Write(geometry))
	.Append('\'');
	if (!defaultSrid)
	{
	builder
	.Append(", ")
	.Append(geometry.SRID);
	}
	builder.Append(')');

...but then simplifies them to string literals when translating methods that take them as parameters:

efcore/src/EFCore.SqlServer.NTS/Query/Internal/SqlServerGeometryMethodTranslator.cs

Lines 189 to 203 in c94a821

	private IEnumerable<SqlExpression> Simplify(IEnumerable<SqlExpression> arguments, bool isGeography)
	{
	foreach (var argument in arguments)
	{
	if (argument is SqlConstantExpression constant
	&& constant.Value is Geometry geometry
	&& geometry.SRID == (isGeography ? 4326 : 0))
	{
	yield return _sqlExpressionFactory.Fragment("'" + geometry.AsText() + "'");
	continue;
	}
	yield return argument;
	}
	}